Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable include-hidden-files for uploading code coverage chunks #12839

Conversation

johansenja
Copy link
Contributor

@johansenja johansenja commented Sep 3, 2024

What? Why?

It looks like it could be actions/upload-artifact#602 - this project certainly isn't the only one affected! 😅

The partial simplecov reports are all called .resultset.json (or something like that), so they are likely classed as "hidden"

What should we test?

Confirm that all of CI passes and a combined simplecov report is downloadable again

Release notes

  • Technical changes only

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@rioug rioug added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Sep 3, 2024
@rioug rioug self-requested a review September 3, 2024 23:49
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !
There are a lot of people upset with this change 😄

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mkllnk mkllnk merged commit fde18eb into openfoodfoundation:master Sep 4, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants