Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] Bring back auto refresh for Weather Station and HomeCoach #16546

Merged
merged 2 commits into from
Mar 21, 2024
Merged

[netatmo] Bring back auto refresh for Weather Station and HomeCoach #16546

merged 2 commits into from
Mar 21, 2024

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Mar 19, 2024 •
edited
Loading

Resolves #16545
Showed that "netatmo:configurable" is no more used with the introduction of "netatmo:camera"
Proven by a test.

@clinique
Corrects and completes PR openhab#16492
ba22808 
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
@clinique clinique requested a review from lolodomo as a code owner March 19, 2024 08:29
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. labels Mar 19, 2024
@clinique
Correct documentation
01a8f77 
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
@jlaur
Copy link
Contributor

jlaur commented Mar 19, 2024

Regression of #16492

@clinique clinique requested a review from jlaur March 21, 2024 06:14
@jlaur
Copy link
Contributor

jlaur commented Mar 21, 2024 •
edited
Loading

@lolodomo - can you review this one, since you reviewed also the PR that introduced this regression? If you are short of time, I can probably have a look during the weekend, but I would need to go through both PR's for context.

#16489 is affected/blocked by this.

@lolodomo
Copy link
Contributor

@lolodomo - can you review this one, since you reviewed also the PR that introduced this regression?

Done

@lolodomo lolodomo removed the bug An unexpected problem or unintended behavior of an add-on label Mar 21, 2024
@jlaur
Copy link
Contributor

jlaur commented Mar 21, 2024

@lolodomo - why did you remove the bug label? Since it also has the regression label, it won't be mentioned in release notes, but it's clearly a bug.

@clinique clinique requested a review from lolodomo March 21, 2024 11:38
@lolodomo
Copy link
Contributor

lolodomo commented Mar 21, 2024 •
edited
Loading

@lolodomo - why did you remove the bug label? Since it also has the regression label, it won't be mentioned in release notes, but it's clearly a bug.

Because the regression was introduced after the last release (milestone 1) and before the next release. So we don't want to mention it in next release as no user who installed milestone 1 was impacted.
The regression only impacted users who installed very recent nightly builds.

lolodomo
lolodomo approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit d68adfa into openhab:main Mar 21, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Mar 21, 2024
@jlaur
Copy link
Contributor

jlaur commented Mar 21, 2024

Because the regression was introduced after the last release (milestone 1) and before the next release. So we don't want to mention it in next release as no user who installed milestone 1 was impacted.

It should not be mentioned when there is a "regression" label, that was the idea behind it.

@lolodomo
Copy link
Contributor

It should not be mentioned when there is a "regression" label, that was the idea behind it.

You mean if regression tag is there, we can keep the bug tag and the PR will not be in the release notes?
I thought every PR with bug tag or enhancement tag were taken in release notes.

@jlaur
Copy link
Contributor

jlaur commented Mar 21, 2024

It should not be mentioned when there is a "regression" label, that was the idea behind it.

You mean if regression tag is there, we can keep the bug tag and the PR will not be in the release notes? I thought every PR with bug tag or enhancement tag were taken in release notes.

Exactly, it will be filtered in milestone and final release notes.

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Mar 21, 2024
@clinique clinique deleted the netatmo_16545 branch March 21, 2024 13:51
@jlaur jlaur mentioned this pull request Mar 23, 2024
Open
jlaur pushed a commit to jlaur/openhab-addons that referenced this pull request Mar 23, 2024
@clinique @jlaur
[netatmo] Bring back auto refresh for Weather Station and HomeCoach (o…
2763b54 
…penhab#16546)

* Corrects and completes PR openhab#16492

---------

Signed-off-by: gael@lhopital.org <gael@lhopital.org>
magx2 pushed a commit to magx2/openhab2-addons that referenced this pull request Mar 24, 2024
@clinique @magx2
[netatmo] Bring back auto refresh for Weather Station and HomeCoach (o…
6d9fa2f 
…penhab#16546)

* Corrects and completes PR openhab#16492

---------

Signed-off-by: gael@lhopital.org <gael@lhopital.org>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/netatmo-bridge-offline-99-of-time/149168/28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@jlaur jlaur Awaiting requested review from jlaur

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

[netatmo] Weather Station and Home Coach stay at 3 minutes update rythm
4 participants
@clinique @jlaur @lolodomo @openhab-bot