Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add kafka compress type and producer ack params #1310

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

rfyiamcool
Copy link
Contributor

summary

Allows users to select parameters. 馃榿

The default waitforall is slow because it needs to wait synchronously for the brokers of the isr cluster to synchronize data.

Kafka's compression can appropriately reduce storage in kafka and pod/node bandwidth.

Of course, the effectiveness of parameters still depends on the scenario.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2023
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 09:41 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 09:41 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 09:41 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 09:41 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 09:41 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 09:41 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 31, 2023 09:41 — with GitHub Actions Inactive
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 31, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@cubxxw cubxxw added this pull request to the merge queue Nov 10, 2023
Merged via the queue into openimsdk:main with commit d1af343 Nov 10, 2023
18 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 10, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants