Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: lower the level of code nesting #1370

Merged
merged 2 commits into from
Nov 10, 2023
Merged

refactor: lower the level of code nesting #1370

merged 2 commits into from
Nov 10, 2023

Conversation

rfyiamcool
Copy link
Contributor

summary

lower the level of code nesting for push/push_to_client.go.

@rfyiamcool
refactor: lower the level of code nesting
4609d55 
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
@rfyiamcool
refactor: lower the level of code nesting
e069837 
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2023
@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Nov 8, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

cubxxw
cubxxw approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@cubxxw cubxxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FGadvancer FGadvancer added this pull request to the merge queue Nov 10, 2023
Merged via the queue into openimsdk:main with commit 686fa80 Nov 10, 2023
17 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 10, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 10, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FGadvancer FGadvancer FGadvancer approved these changes

@cubxxw cubxxw cubxxw approved these changes

@skiffer-git skiffer-git Awaiting requested review from skiffer-git skiffer-git is a code owner

@Bloomingg Bloomingg Awaiting requested review from Bloomingg Bloomingg was automatically assigned from openimsdk/openim-all

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@rfyiamcool @FGadvancer @cubxxw