Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: lower the level of code nesting #1396

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

rfyiamcool
Copy link
Contributor

summary

lower the level of code nesting

Copy link
Contributor

sweep-ai bot commented Nov 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #1396 (4177423) into main (0d5fe4e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1396      +/-   ##
========================================
- Coverage   4.35%   4.35%   -0.01%     
========================================
  Files         49      49              
  Lines       4113    4114       +1     
========================================
  Hits         179     179              
- Misses      3922    3923       +1     
  Partials      12      12              
Files Coverage Δ
internal/msggateway/n_ws_server.go 0.00% <0.00%> (ø)
internal/msggateway/hub_server.go 0.00% <0.00%> (ø)

@kubbot kubbot added this pull request to the merge queue Nov 14, 2023
Merged via the queue into openimsdk:main with commit 7502b4a Nov 14, 2023
21 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 14, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants