Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove MySQL and implement it all with Mongo #1508

Merged
merged 75 commits into from
Dec 5, 2023
Merged

feat: Remove MySQL and implement it all with Mongo #1508

merged 75 commits into from
Dec 5, 2023

Conversation

withchao
Copy link
Collaborator

@withchao withchao commented Dec 1, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1507

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

withchao and others added 30 commits November 9, 2023 17:32
# Conflicts:
#	pkg/common/db/controller/msg.go
# Conflicts:
#	pkg/common/db/controller/msg.go
# Conflicts:
#	pkg/common/db/controller/msg.go
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 204 lines in your changes are missing coverage. Please review.

Comparison is base (4b19202) 4.86% compared to head (af951d8) 4.88%.

Files Patch % Lines
pkg/common/db/cache/group.go 0.00% 70 Missing ⚠️
pkg/common/convert/friend.go 0.00% 33 Missing ⚠️
internal/tools/msg.go 0.00% 31 Missing ⚠️
pkg/common/convert/user.go 40.00% 23 Missing and 1 partial ⚠️
pkg/common/db/cache/msg.go 0.00% 13 Missing ⚠️
pkg/common/db/cache/s3.go 0.00% 7 Missing ⚠️
internal/tools/conversation.go 0.00% 6 Missing ⚠️
internal/msggateway/n_ws_server.go 0.00% 5 Missing ⚠️
pkg/common/db/cache/meta_cache.go 0.00% 4 Missing ⚠️
pkg/common/db/cache/user.go 0.00% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1508      +/-   ##
========================================
+ Coverage   4.86%   4.88%   +0.02%     
========================================
  Files         49      42       -7     
  Lines       4256    3787     -469     
========================================
- Hits         207     185      -22     
+ Misses      4037    3592     -445     
+ Partials      12      10       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cubxxw
cubxxw previously approved these changes Dec 1, 2023
@withchao withchao added this pull request to the merge queue Dec 5, 2023
Merged via the queue into openimsdk:main with commit c0194f6 Dec 5, 2023
19 of 20 checks passed
@withchao withchao deleted the mongo branch December 5, 2023 12:53
@github-actions github-actions bot added this to the v3.1 milestone Dec 5, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: Remove MySQL and implement it all with Mongo
4 participants