Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reconstruct the script of 'make start' 'make stop' and 'make check' #1953

Merged
merged 84 commits into from
Feb 27, 2024

Conversation

luhaoling
Copy link
Contributor

@luhaoling luhaoling commented Feb 26, 2024


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1954

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 4.76%. Comparing base (c754ec6) to head (9602498).
Report is 18 commits behind head on main.

Files Patch % Lines
pkg/util/genutil/genutil.go 0.00% 3 Missing ⚠️
pkg/common/startrpc/start.go 0.00% 2 Missing ⚠️
internal/msggateway/init.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1953      +/-   ##
========================================
- Coverage   5.32%   4.76%   -0.56%     
========================================
  Files         43      43              
  Lines       3852    3296     -556     
========================================
- Hits         205     157      -48     
+ Misses      3634    3126     -508     
  Partials      13      13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw
Copy link
Contributor

cubxxw commented Feb 26, 2024

修复脚本 CICD

@kubbot
Copy link
Member

kubbot commented Feb 26, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Repair script CICD

@luhaoling
Copy link
Contributor Author

luhaoling commented Feb 27, 2024

修复脚本 CICD

I have repaired the error of cicd.
Please review again. If there are no problems, please approve the merger

Copy link
Contributor

@cubxxw cubxxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skiffer-git skiffer-git added this pull request to the merge queue Feb 27, 2024
Merged via the queue into openimsdk:main with commit ac87758 Feb 27, 2024
25 checks passed
@skiffer-git skiffer-git deleted the fix/script branch February 27, 2024 09:59
@github-actions github-actions bot added this to the v3.1 milestone Feb 27, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: reconstruct the script of 'make start' 'make stop' and 'make check'
4 participants