Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Logs field type. #662

Merged
merged 28 commits into from
Aug 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
9866fa5
Refactor: reconstruct issue and label in GitHub.
mo3et Aug 8, 2024
2b236d9
update feature-request label.
mo3et Aug 8, 2024
9080b05
update
mo3et Aug 8, 2024
7c3f839
fix: update to correct workflow.
mo3et Aug 8, 2024
eaafc97
Merge branch 'main' of github.com:openimsdk/openim-sdk-core into refa…
mo3et Aug 8, 2024
0091562
fix: remove env.
mo3et Aug 8, 2024
6be8246
Merge branch 'main' of github.com:openimsdk/openim-sdk-core into refa…
mo3et Aug 8, 2024
b111401
fix: remove unused release files.
mo3et Aug 9, 2024
37f3911
Merge branch 'main' of github.com:openimsdk/openim-sdk-core into refa…
mo3et Aug 9, 2024
880216b
refactor: update workflows and remove unnecessary contents.
mo3et Aug 12, 2024
49e580c
Merge branch 'main' of github.com:openimsdk/openim-sdk-core into refa…
mo3et Aug 12, 2024
7d1796e
Fix: remove uncorrect comment.
mo3et Aug 12, 2024
e103572
Merge branch 'main' of github.com:openimsdk/openim-sdk-core into refa…
mo3et Aug 12, 2024
4981c8d
remove labels.
mo3et Aug 12, 2024
114a1ea
update yml
mo3et Aug 12, 2024
3d68019
update
mo3et Aug 12, 2024
260599b
feat: implement log interface.
mo3et Aug 14, 2024
4bd21d5
Merge branch 'openimsdk:main' into refactor/workflows
mo3et Aug 14, 2024
22e902f
update
mo3et Aug 14, 2024
10ff918
Merge branch 'main' of github.com:openimsdk/openim-sdk-core into refa…
mo3et Aug 14, 2024
937c345
Merge branch 'refactor/workflows' of github.com:mo3et/openim-sdk-core…
mo3et Aug 14, 2024
5a8f832
update
mo3et Aug 14, 2024
5b84de1
update.
mo3et Aug 14, 2024
d7d8d3e
fix: update interface func.
mo3et Aug 15, 2024
f3be488
Merge branch 'main' of github.com:openimsdk/openim-sdk-core into refa…
mo3et Aug 15, 2024
66ef1bc
fix: update Logs field type.
mo3et Aug 15, 2024
484cdc0
Merge branch 'main' of github.com:openimsdk/openim-sdk-core into refa…
mo3et Aug 15, 2024
eced5df
update log fields.
mo3et Aug 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/third/log.go
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ func readLastNLines(filename string, n int) ([]string, error) {
return result, nil
}

func (c *Third) Log(ctx context.Context, logLevel int, relativePath string, line string, msg, err string, keysAndValues []any) {
func (c *Third) Log(ctx context.Context, logLevel int, file string, line int, msg, err string, keysAndValues []any) {
switch logLevel {
case 6:
// sdklog.SDKDebug(ctx, path, line, msg, keysAndValues)
Expand Down
4 changes: 2 additions & 2 deletions open_im_sdk/third.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ func UploadLogs(callback open_im_sdk_callback.Base, operationID string, line int
call(callback, operationID, UserForSDK.Third().UploadLogs, line, ex, progress)
}

func Logs(callback open_im_sdk_callback.Base, operationID string, logLevel int, relativePath string, line string, msgs string, err string, keyAndValue string) {
call(callback, operationID, UserForSDK.Third().Log, logLevel, relativePath, line, msgs, err, keyAndValue)
func Logs(callback open_im_sdk_callback.Base, operationID string, logLevel int, file string, line int, msgs string, err string, keyAndValue string) {
call(callback, operationID, UserForSDK.Third().Log, logLevel, file, line, msgs, err, keyAndValue)
}
Loading