Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290000: Bump macOS GitHub actions to macOS 11 #9426

Closed
wants to merge 3 commits into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 8, 2022

macOS 10.15 has been deprecated for some time and will be removed completely on August 30th. See https://github.com/actions/virtual-environments#available-environments and actions/runner-images#5583 for context.

It's also worth pointing out that they are shutting down the agents already which means that we likely see longer wait times for executors so this should speed up the workflow for developers. We'll need to backport this all the way down to JDK8u to avoid breaking the CI system.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9426/head:pull/9426
$ git checkout pull/9426

Update a local copy of the PR:
$ git checkout pull/9426
$ git pull https://git.openjdk.org/jdk pull/9426/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9426

View PR using the GUI difftool:
$ git pr show -t 9426

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9426.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2022

@gdams The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jul 8, 2022
@gdams gdams changed the title Bump macOS GitHub actions to macOS 12 8290000: Bump macOS GitHub actions to macOS 12 Jul 8, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2022

Webrevs

@gdams gdams changed the title 8290000: Bump macOS GitHub actions to macOS 12 8290000: Bump macOS GitHub actions to macOS 11 Jul 8, 2022
@openjdk-notifier
Copy link

@gdams Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@gdams
Copy link
Member Author

gdams commented Jul 18, 2022

cc @erikj79 @magicus I think this PR likely needs one of you to review it? There is a reasonable sense of urgency here because I'm going to need to backport this down to all versions.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. XCode 11.7 is listed as the lowest version supported by macos-11 image.

@openjdk
Copy link

openjdk bot commented Jul 18, 2022

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290000: Bump macOS GitHub actions to macOS 11

Reviewed-by: shade, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 116 new commits pushed to the master branch:

  • 5a96a5d: 8289612: Change hotspot/jtreg tests to not use Thread.stop
  • b65f7ec: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations
  • 6c8d0e6: 8282526: Default icon is not painted properly
  • e72742e: 8286172: Create an automated test for JDK-4516019
  • b9de0a7: 8284524: Create an automated test for JDK-4422362
  • 5ae4320: 8284767: Create an automated test for JDK-4422535
  • efed7a7: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[]
  • b2010a7: 8287805: Shenandoah: consolidate evacuate-update-root closures
  • ea8b75c: 8290334: Update FreeType to 2.12.1
  • 6882f0e: 8290013: serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed "assert(!in_vm) failed: Undersized StackShadowPages"
  • ... and 106 more: https://git.openjdk.org/jdk/compare/d852e99ae9de4c611438c50ce37ea1806f58cbdf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 18, 2022
@gdams
Copy link
Member Author

gdams commented Jul 18, 2022

/integrate

@gdams
Copy link
Member Author

gdams commented Jul 18, 2022

Thanks for the review @shipilev! Are you willing to sponsor?

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 18, 2022
@openjdk
Copy link

openjdk bot commented Jul 18, 2022

@gdams
Your change (at version bbb2758) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

I shall wait for some more people to ack this, and then I can sponsor.

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine, reading the matrix at https://wiki.openjdk.org/display/Build/Supported+Build+Platforms and taking into account the deprecation of macos-10.15 as runner platform in Github Actions.

@shipilev
Copy link
Member

All right then! I was thinking if we should do XCode 12.4 then, to align better with the matrix. But since this patch is targeted for backporting, it would probably be better to stick to the lowest toolchain version.

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 19, 2022

Going to push as commit 4e6cd67.
Since your change was applied there have been 121 commits pushed to the master branch:

  • af86cd3: 8290463: Fix several comment typos in sun.security.ec
  • 6cd1c0c: Merge
  • 2677dd6: 8289954: C2: Assert failed in PhaseCFG::verify() after JDK-8183390
  • 4f3f74c: 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible
  • 4a4d8ed: 8289801: [IR Framework] Add flags to whitelist which can be used to simulate a specific machine setup like UseAVX
  • 5a96a5d: 8289612: Change hotspot/jtreg tests to not use Thread.stop
  • b65f7ec: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations
  • 6c8d0e6: 8282526: Default icon is not painted properly
  • e72742e: 8286172: Create an automated test for JDK-4516019
  • b9de0a7: 8284524: Create an automated test for JDK-4422362
  • ... and 111 more: https://git.openjdk.org/jdk/compare/d852e99ae9de4c611438c50ce37ea1806f58cbdf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2022
@openjdk openjdk bot closed this Jul 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 19, 2022
@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@shipilev @gdams Pushed as commit 4e6cd67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the macos_12 branch July 19, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants