Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the use of Java 17 in tests #604

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Allow the use of Java 17 in tests #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db3b6ef
Allow the use of Java 17 in tests
timtebeek Jul 19, 2023
b767fee
Drop reference to outdated bootstrap from README.md
timtebeek Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 0 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,6 @@ All tests can be run from the command line using:

If you're looking for more information on the output from a test, try checking the `target/maven-it/**/*IT/**` directory contents after running the tests. It will contain the project state output, including maven logs, etc. Check the [`Integration Testing Framework Users Guide`](https://khmarbaise.github.io/maven-it-extension/itf-documentation/usersguide/usersguide.html) for information, too. It's good.

### Using this plugin against itself

The `pom.xml` file contains a `bootstrap` profile to use the `rewrite-maven-plugin` against itself (it's a helpful plugin, why not use it to help develop itself?).

```sh
./mvnw -Pbootstrap rewrite:dryRun
```

## Contributing

We appreciate all types of contributions. See the [contributing guide](https://github.com/openrewrite/.github/blob/main/CONTRIBUTING.md) for detailed instructions on how to get started.
Expand Down
28 changes: 3 additions & 25 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<java.version>1.8</java.version>

<maven.compiler.testSource>17</maven.compiler.testSource>
<maven.compiler.testTarget>17</maven.compiler.testTarget>

<!-- dependencies and plugins -->
<jackson-bom.version>2.15.2</jackson-bom.version>
<netty.version>4.1.94.Final</netty.version>
Expand Down Expand Up @@ -299,7 +302,6 @@

<!-- JUnit Jupiter, and using itf-jupiter-extension to get itf support for executing everything as Maven tests -->
<dependency>

<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
Expand All @@ -321,7 +323,6 @@
<scope>test</scope>
</dependency>
<!-- Using assertj as well as custom assertions of AssertJ provided by itf-assertj -->
<!-- If you don’t want to use AssertJ as assertion framework you can omit them both -->
<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
Expand Down Expand Up @@ -611,29 +612,6 @@
</developerConnectionUrl>
</properties>
</profile>
<profile>
<!-- for applying versions of the rewrite-maven-plugin against itself. -->
<!-- if you wanted to try using the plugin with changes made locally, you could run ./mvnw install, then set the plugin version below to the current version of the plugin being developed. -->
<!-- ./mvnw -Pbootstrap rewrite:help -->
<id>bootstrap</id>
<build>
<plugins>
<plugin>
<groupId>org.openrewrite.maven</groupId>
<artifactId>rewrite-maven-plugin</artifactId>
<version>4.40.0</version>
<configuration>
<activeRecipes>
<recipe>org.openrewrite.java.format.AutoFormat</recipe>
</activeRecipes>
</configuration>
</plugin>
</plugins>
</build>
<properties>
<maven.test.skip>true</maven.test.skip>
</properties>
</profile>
</profiles>

<repositories>
Expand Down