Clear project.build.sourceEncoding after parsing sources
#735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timtebeek Thank you! I confirm that this patch does solve by issue. |
src/main/java/org/openrewrite/maven/MavenMojoProjectParser.java
Outdated
Show resolved
Hide resolved
timtebeek
commented
Feb 12, 2024
src/main/java/org/openrewrite/maven/MavenMojoProjectParser.java
Outdated
Show resolved
Hide resolved
| JavaParser.Builder<? extends JavaParser, ?> javaParserBuilder = JavaParser.fromJavaVersion() | ||
| .styles(styles) | ||
| .logCompilationWarningsAndErrors(false); | ||
|
|
||
| Object mavenSourceEncoding = mavenProject.getProperties().get("project.build.sourceEncoding"); |
There was a problem hiding this comment.
Ideally, we would also accept the encoding from the compiler plugin configuration: https://www.baeldung.com/maven-encoding
There was a problem hiding this comment.
done in 175d711 , thanks!
There was a problem hiding this comment.
Were you able to check if the precedence is correct between the plugin configuration and the project property?
There was a problem hiding this comment.
Hard to find any exact sources on what takes precedence, but reading this it's likely the plugin indeed.
https://maven.apache.org/plugins/maven-resources-plugin/examples/encoding.html
knutwannheden
approved these changes
Feb 20, 2024
timtebeek
deleted the
clear-project.build.sourceEncoding-after-parsing-sources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Wasn't sure if this exactly captures the issue described in #734 ; from the description there this seemed a good first step.
Anyone you would like to review specifically?
@leveretconey
Have you considered any alternatives or workarounds?
Not really sure we have a lot of other options here; but open to help explore.