Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XSLT transformation recipe #3606

Merged
merged 26 commits into from
Jul 14, 2024

Conversation

ammachado
Copy link
Contributor

@ammachado ammachado commented Oct 7, 2023

What's changed?

Allow ChangePluginConfiguration to perform XSLT transformation on plugin configuration. Also, added a new recipe for arbitrary XSLT transformations.

What's your motivation?

Perform XSLT transformations on XML files and on Maven plugin configuration.

Anything in particular you'd like reviewers to focus on?

No

Anyone you would like to review specifically?

No

Have you considered any alternatives or workarounds?

FindAndReplace works for simple refactoring, but this allow more complex scenarios.

Any additional context

No

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work already; thanks for getting this started! Curious to hear what you intend to use if for. I've gone through for a first round of review comments, let me know how you feel about what I've raised so far!

@timtebeek timtebeek added the recipe Requested Recipe label Oct 11, 2023
@ammachado
Copy link
Contributor Author

Impressive work already; thanks for getting this started! Curious to hear what you intend to use if for. I've gone through for a first round of review comments, let me know how you feel about what I've raised so far!

The original idea came from upgrading jaxb2-maven-plugin version 1.x (javax.xml) to 3.x (jakarta.xml).

@timtebeek timtebeek self-requested a review June 13, 2024 16:48
github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions[bot]

This comment was marked as outdated.

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Added some minor polishing but otherwise good to go if you ask me. I'll leave a little room for further feedback before I merge, but will merge before the next release.

And thank for the kind contribution, explaining your intended use, and patience in seeing this through.

@timtebeek timtebeek self-requested a review July 13, 2024 14:51
@timtebeek timtebeek merged commit c24ec1c into openrewrite:main Jul 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe Requested Recipe
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants