Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change maven managed dependency classifier #4317

Merged
merged 2 commits into from
Jul 11, 2024
Merged

feat: Change maven managed dependency classifier #4317

merged 2 commits into from
Jul 11, 2024

Conversation

Ferioney
Copy link
Contributor

Fix #4316

@Ferioney Ferioney marked this pull request as ready for review July 10, 2024 10:39
@timtebeek timtebeek added the enhancement New feature or request label Jul 10, 2024
@timtebeek timtebeek self-requested a review July 10, 2024 10:46
@timtebeek timtebeek changed the title feat: Fix #4316 feat: Change maven managed dependency classifier #4316 Jul 11, 2024
@timtebeek timtebeek changed the title feat: Change maven managed dependency classifier #4316 feat: Change maven managed dependency classifier Jul 11, 2024
@timtebeek timtebeek merged commit 3477259 into openrewrite:main Jul 11, 2024
2 checks passed
timtebeek
timtebeek reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here @Ferioney ; thanks a lot for adding this in the minimally intrusive way for backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek left review comments

Assignees

@Ferioney Ferioney

Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change maven managed dependency classifier
2 participants
@Ferioney @timtebeek