Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gradle Enterprise to Develocity 3.17+ migration recipe for Gradle #4320

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

shanman190
Copy link
Contributor

What's changed?

Add migration recipe for Gradle projects to take existing Gradle Enterprise configurations and migrate those to their Develocity counterpart.

What's your motivation?

Fixes #4135.

Anything in particular you'd like reviewers to focus on?

Nothing in particular.

Anyone you would like to review specifically?

Anyone

Have you considered any alternatives or workarounds?

Do the migration manually

Any additional context

https://docs.gradle.com/enterprise/gradle-plugin/legacy/#develocity_migration

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@shanman190 shanman190 self-assigned this Jul 10, 2024
@shanman190 shanman190 added enhancement New feature or request recipe Requested Recipe labels Jul 10, 2024
@shanman190 shanman190 marked this pull request as ready for review July 10, 2024 23:30
@shanman190 shanman190 force-pushed the feature/develocity-migration-gradle branch from adab889 to d9dffd3 Compare July 10, 2024 23:32
@shanman190 shanman190 force-pushed the feature/develocity-migration-gradle branch from d9dffd3 to f3d591e Compare July 11, 2024 00:03
@shanman190
Copy link
Contributor Author

shanman190 commented Jul 11, 2024

One more possible addition would be to handle the build cache extension handler as seen in the rewrite's own configuration done here:
36291f2

  develocity {
      buildCache {
-          remote(gradleEnterprise.buildCache) {
+          remote(develocity.buildCache) {
               ...
           }
      }
  }

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see! I like how you work around not having a GradleTemplate helper with the GradleParser, and still ensure you use the right indentation.

@shanman190 shanman190 merged commit 38d9981 into main Jul 11, 2024
2 checks passed
@shanman190 shanman190 deleted the feature/develocity-migration-gradle branch July 11, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request recipe Requested Recipe
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Migrate from Gradle Enterprise gradle plugin to Develocity plugin
2 participants