Gradle UpgradeDependencyVersion visitor should override isAcceptable #4327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
We returned a TreeVisitor from
getVisitor(Accumulator)
, which then implicitly returns true, meaning we incorrectly skipped the Maven visitor forpom.xml
files, calling the Gradle visitor instead. https://github.com/openrewrite/rewrite-java-dependencies/blob/2e3f39c4863b943cdaacb39d0e788c9c73e3f949/src/main/java/org/openrewrite/java/dependencies/UpgradeTransitiveDependencyVersion.java#L128-L133With this change we only return true for Groovy and Properties files, as we should.
What's your motivation?