Skip to content

Commit

Permalink
[BUG][TSVB] Fix serial diff agg link
Browse files Browse the repository at this point in the history
Doc link was invalid and causing an undefined error. This
prevented the UI from mounting properly.

Issue(s) resolved:
* #3498
* #3327

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
  • Loading branch information
kavilla committed Feb 28, 2023
1 parent 5af9a43 commit 20cb157
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Viz Builder] Add index pattern info when loading embeddable ([#2363](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2363))
- Fixes management app breadcrumb error ([#2344](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2344))
- [BUG] Fix suggestion list cutoff issue ([#2607](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2607))
- [TSVB] Fixes undefined serial diff aggregation documentation link ([#3503](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3503))

### 🚞 Infrastructure

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ export const SerialDiffAgg = (props) => {
const handleNumberChange = createNumberHandler(handleChange);

const htmlId = htmlIdGenerator();
const docLinks = useOpenSearchDashboards().services.docLinks;
const serialDiffDoc = useOpenSearchDashboards().services.docLinks?.links.opensearch.aggregations
.pipeline.serial_diff;

return (
<AggRow
Expand Down Expand Up @@ -111,7 +112,7 @@ export const SerialDiffAgg = (props) => {
id="visTypeTimeseries.serialDiff.lagLabel"
defaultMessage="Lag"
description={`'Lag' refers to the parameter name of the serial diff translation
${docLinks.services.links.opensearch.aggregations.pipeline.serial_diff}.
${serialDiffDoc}.
This should only be translated if there is a reasaonable word explaining what that parameter does.`}
/>
}
Expand Down

0 comments on commit 20cb157

Please sign in to comment.