Merge branch 'main' into reactflow-fix

opensearch-project · Sep 22, 2023 · 3ec840d · 3ec840d
2 parents 1665580 + a10f1c7
commit 3ec840d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -52,6 +52,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Fix broken app when management is turned off ([#4891](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4891))
 - Correct the generated path for downloading plugins by their names on Windows ([#4953](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4953))
 - [BUG] Fix buildPointSeriesData unit test fails due to local timezone ([#4992](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4992))
+- [BUG][Data Explorer][Discover] Fix total hits issue for no time based data ([#5087](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5087))
 
 ### 🚞 Infrastructure
 

diff --git a/src/plugins/discover/public/application/components/chart/chart.tsx b/src/plugins/discover/public/application/components/chart/chart.tsx
@@ -21,8 +21,8 @@ import { useDiscoverContext } from '../../view_components/context';
 import { setInterval, useDispatch, useSelector } from '../../utils/state_management';
 
 interface DiscoverChartProps {
-  bucketInterval: TimechartHeaderBucketInterval;
-  chartData: Chart;
+  bucketInterval?: TimechartHeaderBucketInterval;
+  chartData?: Chart;
   config: IUiSettingsClient;
   data: DataPublicPluginStart;
   hits: number;

diff --git a/...blic/application/components/doc_viewer_links/__snapshots__/doc_viewer_links.test.tsx.snap b/...blic/application/components/doc_viewer_links/__snapshots__/doc_viewer_links.test.tsx.snap
diff --git a/src/plugins/discover/public/application/view_components/canvas/discover_chart_container.tsx b/src/plugins/discover/public/application/view_components/canvas/discover_chart_container.tsx
@@ -20,7 +20,7 @@ export const DiscoverChartContainer = ({ hits, bucketInterval, chartData }: Sear
     indexPattern,
   ]);
 
-  if (!hits || !chartData || !bucketInterval) return null;
+  if (!hits) return null;
 
   return (
     <DiscoverChart