Skip to content

Commit

Permalink
[Fix] ValidationError when setting `maps.proxyOpenSearchMapsServiceIn…
Browse files Browse the repository at this point in the history
…Maps` (#5170)

* Update index.ts args

---------

Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Signed-off-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
  • Loading branch information
4 people committed Oct 18, 2023
1 parent 7b3a9f6 commit 466d298
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Table Vis] Fix filter actions on data table vis cells ([#4837](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4837))
- Fix broken app when management is turned off ([#4891](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4891))
- Correct the generated path for downloading plugins by their names on Windows ([#4953](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4953))
- Fix `maps.proxyOpenSearchMapsServiceInMaps` config definition so it can be set ([#5170](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5170))
- Fix `buildPointSeriesData` unit test fails due to local timezone ([#4992](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4992))
- [Data Explorer][Discover] Fix total hits issue for no time based data ([#5087](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5087))
- [Data Explorer][Discover] Add onQuerySubmit to top nav and allow force update to embeddable ([#5160](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5160))
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/maps_legacy/server/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const config: PluginConfigDescriptor<MapsLegacyConfig> = {
schema: configSchema,
deprecations: ({ renameFromRoot }) => [
renameFromRoot('map.includeElasticMapsService', 'map.includeOpenSearchMapsService'),
renameFromRoot('map.proxyOpenSearchMapsServiceInMaps', 'map.proxyElasticMapsServiceInMaps'),
renameFromRoot('map.proxyElasticMapsServiceInMaps', 'map.proxyOpenSearchMapsServiceInMaps'),
renameFromRoot(
'map.regionmap.includeElasticMapsService',
'map.regionmap.includeOpenSearchMapsService'
Expand Down

0 comments on commit 466d298

Please sign in to comment.