Skip to content

Commit

Permalink
[CI][Cypress][Bug] use default SOURCE inputs (#5197)
Browse files Browse the repository at this point in the history
#5134

Incorrectly uses the source of the code to pull down to BASE REF,
which would likely be `main` or `2.x`, etc.

It should be pulling down the PR branch. Cypress tests at the time
of merging were failing due to unrelated issue of disk allocation.

Not setting the env variables causes the workflow to rely on the default
values which is a return back to the original implementation and if the
env is set then it will be not empty.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
  • Loading branch information
kavilla committed Oct 4, 2023
1 parent 3024c6a commit dc6a7ec
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/cypress_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ on:
type: string

env:
SOURCE_REPO: ${{ github.repository }}
SOURCE_BRANCH: "${{ github.base_ref }}"
TEST_REPO: ${{ inputs.test_repo != '' && inputs.test_repo || 'opensearch-project/opensearch-dashboards-functional-test' }}
TEST_BRANCH: "${{ inputs.test_branch != '' && inputs.test_branch || github.base_ref }}"
FTR_PATH: 'ftr'
Expand Down

0 comments on commit dc6a7ec

Please sign in to comment.