Use @osd/std to stringify JSON when formatting objects for display

Signed-off-by: Miki <miki@amazon.com>
opensearch-project · Sep 18, 2024 · f796925 · f796925
1 parent cc5531b
commit f796925
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/plugins/data/common/field_formats/utils/as_pretty_string.test.ts b/src/plugins/data/common/field_formats/utils/as_pretty_string.test.ts
@@ -42,7 +42,11 @@ describe('asPrettyString', () => {
   });
 
   test('Converts objects values into presentable strings', () => {
-    expect(asPrettyString({ key: 'value' })).toBe('{\n  "key": "value"\n}');
+    const longPositive = BigInt(Number.MAX_SAFE_INTEGER) * 2n;
+    const longNegative = BigInt(Number.MIN_SAFE_INTEGER) * 2n;
+    expect(asPrettyString({ key: 'value', longPositive, longNegative })).toBe(
+      `{\n  "key": "value",\n  "longPositive": ${longPositive.toString()},\n  "longNegative": ${longNegative.toString()}\n}`
+    );
   });
 
   test('Converts other non-string values into strings', () => {

diff --git a/src/plugins/data/common/field_formats/utils/as_pretty_string.ts b/src/plugins/data/common/field_formats/utils/as_pretty_string.ts
@@ -28,6 +28,8 @@
  * under the License.
  */
 
+import { stringify } from '@osd/std';
+
 /**
  * Convert a value to a presentable string
  */
@@ -37,7 +39,7 @@ export function asPrettyString(val: any): string {
     case 'string':
       return val;
     case 'object':
-      return JSON.stringify(val, null, '  ');
+      return stringify(val, null, '  ');
     default:
       return '' + val;
   }