Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use scripts/use_node instead of node #3719

Open
kavilla opened this issue Mar 28, 2023 · 0 comments
Open

Use scripts/use_node instead of node #3719

kavilla opened this issue Mar 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@kavilla
Copy link
Member

kavilla commented Mar 28, 2023

Origin: #3508

The default scripts and generation scripts have been updated to utilize the script use_node which allows for environment variable controlled version of node to be utilized before falling back to use the bundled or system-wide Node.js binary.

As you can see here:
https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/package.json#L43

we utilize the new scripts. Plugins don't need to be able to develop but for a more cohesive developer experience plugins should onboard to utilizing the script.

For example: https://github.com/opensearch-project/dashboards-maps/blob/main/package.json#L10
@kavilla kavilla added the enhancement New feature or request label Mar 28, 2023
@kavilla kavilla removed the untriaged label Mar 28, 2023
andreymyssak added a commit to andreymyssak/OpenSearch-Dashboards that referenced this issue Apr 4, 2023
@andreymyssak @SergeyMyssak
Replace node with scripts/use_node (opensearch-project#3719)
166906f 
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
@andreymyssak andreymyssak mentioned this issue Apr 4, 2023
Merged
8 tasks
andreymyssak added a commit to andreymyssak/OpenSearch-Dashboards that referenced this issue Apr 4, 2023
@andreymyssak @SergeyMyssak
Update CHANGELOG.md (opensearch-project#3719)
c524293 
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
andreymyssak added a commit to andreymyssak/OpenSearch-Dashboards that referenced this issue Apr 5, 2023
@andreymyssak @SergeyMyssak
Update CHANGELOG.md (opensearch-project#3719)
4c87c16 
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
AMoo-Miki pushed a commit that referenced this issue Apr 15, 2023
@andreymyssak @SergeyMyssak @joshuarrrr
[CCI] Replace node with scripts/use_node in functional tests (#3783)
8f890e9 
* Replace node with scripts/use_node (#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

* Update CHANGELOG.md (#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

---------

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 18, 2023
@github-actions
[CCI] Replace node with scripts/use_node in functional tests (#3783)
45643fd 
* Replace node with scripts/use_node (#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

* Update CHANGELOG.md (#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

---------

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 8f890e9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
joshuarrrr pushed a commit that referenced this issue Apr 19, 2023
@opensearch-trigger-bot @github-actions
[CCI] Replace node with scripts/use_node in functional tests (#3783…
6796992 
…) (#3881)

* Replace node with scripts/use_node (#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

* Update CHANGELOG.md (#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

---------

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 8f890e9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 19, 2023
@github-actions
[CCI] Replace node with scripts/use_node in functional tests (#3783…
259f731 
…) (#3881)

* Replace node with scripts/use_node (#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

* Update CHANGELOG.md (#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

---------

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 8f890e9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 6796992)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc pushed a commit that referenced this issue Apr 20, 2023
@opensearch-trigger-bot @github-actions
[CCI] Replace node with scripts/use_node in functional tests (#3783…
5e8c7cd 
…) (#3881) (#3892)

* Replace node with scripts/use_node (#3719)




* Update CHANGELOG.md (#3719)




---------




(cherry picked from commit 8f890e9)


# Conflicts:
#	CHANGELOG.md


(cherry picked from commit 6796992)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this issue Apr 24, 2023
@andreymyssak @SergeyMyssak
@joshuarrrr @sikhote
[CCI] Replace node with scripts/use_node in functional tests (ope…
90de142 
…nsearch-project#3783)

* Replace node with scripts/use_node (opensearch-project#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

* Update CHANGELOG.md (opensearch-project#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

---------

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
zhongnansu pushed a commit to zhongnansu/OpenSearch-Dashboards that referenced this issue May 3, 2023
@andreymyssak @zhongnansu
[CCI] Replace node with scripts/use_node in functional tests (ope…
614ce38 
…nsearch-project#3783)

* Replace node with scripts/use_node (opensearch-project#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

* Update CHANGELOG.md (opensearch-project#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

---------

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 8f890e9)
@zhongnansu zhongnansu mentioned this issue May 3, 2023
Merged
8 tasks
opensearch-trigger-bot bot pushed a commit that referenced this issue May 11, 2023
@github-actions @andreymyssak
[CCI] Replace node with scripts/use_node in functional tests (#3783…
029db43 
…) (#3970)

* Replace node with scripts/use_node (#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

* Update CHANGELOG.md (#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

---------

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 8f890e9)

Co-authored-by: Andrey Myssak <40265277+andreymyssak@users.noreply.github.com>
(cherry picked from commit 501ba8a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
seanneumann pushed a commit to ananzh/OpenSearch-Dashboards that referenced this issue May 11, 2023
@zhongnansu @andreymyssak
[CCI] Replace node with scripts/use_node in functional tests (ope…
501ba8a 
…nsearch-project#3783) (opensearch-project#3970)

* Replace node with scripts/use_node (opensearch-project#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

* Update CHANGELOG.md (opensearch-project#3719)

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>

---------

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 8f890e9)

Co-authored-by: Andrey Myssak <40265277+andreymyssak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kavilla