Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Research][Functional Test] why setDefaultAbsoluteRange is not robust for Discover in plugin_functional test #5241

Closed
ananzh opened this issue Oct 6, 2023 · 0 comments

Comments

@ananzh
Copy link
Member

ananzh commented Oct 6, 2023

Describe the bug

private async showStartEndTimes() {
      // This first await makes sure the superDatePicker has loaded before we check for the ShowDatesButton
      await testSubjects.exists('superDatePickerToggleQuickMenuButton', { timeout: 20000 });
      const isShowDatesButton = await testSubjects.exists('superDatePickerShowDatesButton');
      if (isShowDatesButton) {
        await testSubjects.click('superDatePickerShowDatesButton');
      }
      await testSubjects.exists('superDatePickerstartDatePopoverButton');
    }
issue.mov
  • Sometime time is not set. I still see the original time not input time.
  • Need to modify test_suites/doc_views_links because currently we open links in new tab
  • Need to modify test_suites/doc_views because we uses data grid for table

To Reproduce
Use DCV or any similar with GUI.

  • run opensearch
  • run opensearch dashboards: yarn start --no-base-path
  • node scripts/build_opensearch_dashboards_platform_plugins --no-examples --workers 10 --scan-dir "./test/plugin_functional/plugins"
  • node scripts/functional_tests.js --config test/plugin_functional/config.ts
@ananzh ananzh added bug Something isn't working v2.11.0 labels Oct 6, 2023
@ananzh ananzh self-assigned this Oct 6, 2023
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Oct 7, 2023
…date doc views tests

* add a helper function setInputValueWithRetry for setAbsoluteRange to retry
time range setup
* update doc_views test to click docTableExpandToggleColumn-0
* update doc_views_link to check new tab

Issue Resolve
opensearch-project#5241

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Oct 7, 2023
…date doc views tests

* add a helper function setInputValueWithRetry for setAbsoluteRange to retry
time range setup
* update doc_views test to click docTableExpandToggleColumn-0
* update doc_views_link to check new tab

Issue Resolve
opensearch-project#5241

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Oct 7, 2023
…date doc views tests

* add a helper function setInputValueWithRetry for setAbsoluteRange to retry
time range setup
* update doc_views test to click docTableExpandToggleColumn-0
* update doc_views_link to check new tab

Issue Resolve
opensearch-project#5241

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Oct 9, 2023
…date doc views tests

* add a helper function setInputValueWithRetry for setAbsoluteRange to retry
time range setup
* update doc_views test to click docTableExpandToggleColumn-0
* update doc_views_link to check new tab

Issue Resolve
opensearch-project#5241

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh changed the title [BUG][Functional Test] setDefaultAbsoluteRange is not robust and doc views tests require update [Research][Functional Test] why setDefaultAbsoluteRange is not robust for Discover in plugin_functional test Oct 9, 2023
@ananzh ananzh removed the bug Something isn't working label Oct 9, 2023
@ananzh ananzh closed this as completed in d6345f3 Oct 9, 2023
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 9, 2023
…date doc views tests (#5242)

* [BUG][Fuctional Test] Make setDefaultAbsoluteRange more robust and update doc views tests

* fix PR comment by making a special time picker method for discover
* update doc_views test to click docTableExpandToggleColumn-0
* update doc_views_link to check new tab

Issue Resolve
#5241

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit d6345f3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 9, 2023
…date doc views tests (#5242)

* [BUG][Fuctional Test] Make setDefaultAbsoluteRange more robust and update doc views tests

* fix PR comment by making a special time picker method for discover
* update doc_views test to click docTableExpandToggleColumn-0
* update doc_views_link to check new tab

Issue Resolve
#5241

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit d6345f3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ashwin-pc pushed a commit that referenced this issue Oct 10, 2023
…date doc views tests (#5242) (#5256)

* [BUG][Fuctional Test] Make setDefaultAbsoluteRange more robust and update doc views tests

* fix PR comment by making a special time picker method for discover
* update doc_views test to click docTableExpandToggleColumn-0
* update doc_views_link to check new tab

Issue Resolve
#5241

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit d6345f3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc pushed a commit that referenced this issue Oct 10, 2023
…date doc views tests (#5242) (#5255)

* [BUG][Fuctional Test] Make setDefaultAbsoluteRange more robust and update doc views tests

* fix PR comment by making a special time picker method for discover
* update doc_views test to click docTableExpandToggleColumn-0
* update doc_views_link to check new tab

Issue Resolve
#5241

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit d6345f3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant