Migrate from Node Sass to Dart Sass #535
Labels
build
Build related additions or modifications
dependencies
Pull requests that update a dependency file
technical debt
If not paid, jeapardizes long-term success and maintainability of the repository.
Comments
tmarkley
added
build
tmarkley
added
the
technical debt
7 tasks
7 tasks
kavilla
pushed a commit
that referenced
this issue
Aug 12, 2022
https://github.com/opensearch-project/OpenSearch-Dashboards/security/dependabot/62 This PR fixes the Regular expression denial of service in scss-tokenizer, use dart-sass instead of node-sass. The node-sass are deprecated, the detail here. https://www.npmjs.com/package/node-sass The suggested solution (#535) is that use dart-sass instead of node-sass * use dart-sass instead of node-sass * Update basic_optimization.test snapshot * use compressed as outputsytle and fixes yarn.lock * minimize yarn.lock changes Issues Resolved: #1842 #535 Signed-off-by: Tao liu <liutaoaz@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Node Sass and LibSass are deprecated: https://sass-lang.com/blog/libsass-is-deprecated
Describe the solution you'd like
Migrate to Dart Sass: https://sass-lang.com/dart-sass
Describe alternatives you've considered
A temporary version bump was done in #501 to use a newer version of LibSass that addresses current security vulnerabilities. An upgrade to Dart Sass was attempted but resulted in errors since EUI does not follow the Sass spec. For example:
SassError: Top-level selectors may not contain the parent selector "&".Additional context
N/A
The text was updated successfully, but these errors were encountered: