Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support header nav to register nav control to farthest right #5458

Open
Hailong-am opened this issue Nov 10, 2023 · 1 comment
Open

Support header nav to register nav control to farthest right #5458

Hailong-am opened this issue Nov 10, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Hailong-am
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Support header nav to register nav control to farthest right. For now, help Menu always be the farthest right.

<EuiHeaderSectionItem border="left">
    <HeaderNavControls navControls$={observables.navControlsRight$} />
  </EuiHeaderSectionItem>

  <EuiHeaderSectionItem border="left">
    <HeaderHelpMenu
      helpExtension$={observables.helpExtension$}
      helpSupportUrl$={observables.helpSupportUrl$}
      opensearchDashboardsDocLink={opensearchDashboardsDocLink}
      opensearchDashboardsVersion={opensearchDashboardsVersion}
      surveyLink={survey}
    />
</EuiHeaderSectionItem>

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/core/public/chrome/ui/header/header.tsx#L230-L242

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@Hailong-am Hailong-am added the enhancement New feature or request label Nov 10, 2023
@joshuarrrr
Copy link
Member

@kgcreative I'd like a little more guidance here - we already have a lot of header nav entry points, and if we add a new one, even the naming will start to get confusing. Furthermore, what are the guiding design principles we'd like plugin authors to follow in terms of registering their nav item to the left or the right of the help menu? Is there some heuristic to follow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants