Add border for header navigation on right #5450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
Hailong-am
changed the title
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #5450 +/- ##
==========================================
- Coverage 66.82% 66.82% -0.01%
==========================================
Files 3291 3291
Lines 63174 63174
Branches 10055 10055
==========================================
- Hits 42219 42213 -6
- Misses 18471 18479 +8
+ Partials 2484 2482 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AMoo-Miki
previously approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Thanks. I would however wait to hear from @kgcreative before merging this.
Make it so! |
|
Also nitpick, but when adding this item, it should to all the way to the right |
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Current header don't support register Nav to farthest right, have another issue #5458 to track |
AMoo-Miki
approved these changes
Nov 15, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
* Add border for header navigtion ight Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add changelog Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit f6ce6e7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Add border for header navigtion ight * Add changelog --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit f6ce6e7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add border for header navigation control on right
Issues Resolved
#5449
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration