Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Discover crashed when loading a saved search from saved object list in dashboards management #5942

Closed
mengweieric opened this issue Feb 24, 2024 · 2 comments
Closed

[BUG] Discover crashed when loading a saved search from saved object list in dashboards management #5942

mengweieric opened this issue Feb 24, 2024 · 2 comments
Assignees
@ananzh
Labels
bug Something isn't working discover for discover reinvent v2.16.0

Comments

@mengweieric
Copy link
Collaborator

Describe the bug

Discover crashed when loading a saved search from saved object list in dashboards management.

To Reproduce
Steps to reproduce the behavior:

  1. in Discover page, do a query search (or even without any change)
  2. Click on save icon beside query bar
  3. click save current query
  4. go to 'saved objects' of Dashboards management, search for the query saved above
  5. click on it to load it in discover
  6. Discover page crashed

Expected behavior
Discover should load the saved search correctly.

OpenSearch Version
2.11.0

Dashboards Version
2.11.0

Plugins

N/A

Screenshots

Saved.query.crash.mov

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.
@mengweieric mengweieric added bug Something isn't working untriaged labels Feb 24, 2024
@ashwin-pc ashwin-pc added discover for discover reinvent and removed untriaged labels Feb 24, 2024
@mengweieric mengweieric mentioned this issue Feb 24, 2024
Closed
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Feb 26, 2024
@ananzh
[Discover] Allow save query to load correctly in Discover
2a3d8f5 
* add save query logic in Discover
* add save query logic in VisBuilder

Issue Resolve
opensearch-project#5942

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Feb 26, 2024
@ananzh
[Discover] Allow save query to load correctly in Discover
366d604 
* add save query logic in Discover
* add save query logic in VisBuilder

Issue Resolve
opensearch-project#5942

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Feb 26, 2024
@ananzh
[Discover] Allow save query to load correctly in Discover
6dca3c8 
* add save query logic in Discover
* add save query logic in VisBuilder

Issue Resolve
opensearch-project#5942

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Feb 26, 2024
Merged
7 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Feb 26, 2024
@ananzh
[Discover] Allow save query to load correctly in Discover
56411ba 
* add save query logic in Discover
* add save query logic in VisBuilder
* remove double render

Issue Resolve
opensearch-project#5942

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh
Copy link
Member

ananzh commented Feb 26, 2024

VisBuilder missed save query logic as well. Will fix them together.

ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Feb 26, 2024
@ananzh
[Discover] Allow save query to load correctly in Discover
1dfcaef 
* add save query logic in Discover
* add save query logic in VisBuilder
* remove double render

Issue Resolve
opensearch-project#5942

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Feb 27, 2024
Open
11 tasks
ananzh added a commit that referenced this issue Feb 27, 2024
@ananzh
[Discover] Allow save query to load correctly in Discover
68c9698 
* add save query logic in Discover
* add save query logic in VisBuilder
* remove double render

Issue Resolve
#5942

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Mar 14, 2024
@ananzh
[Discover] Allow save query to load correctly in Discover
8cd819e 
* add save query logic in Discover
* add save query logic in VisBuilder
* remove double render

Issue Resolve
opensearch-project#5942

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Mar 15, 2024
@ananzh
[Discover] Allow save query to load correctly in Discover
419f0da 
* add save query logic in Discover
* add save query logic in VisBuilder
* remove double render

Issue Resolve
opensearch-project#5942

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Mar 15, 2024
@ananzh
[Discover] Allow save query to load correctly in Discover
5b6a765 
* add save query logic in Discover
* add save query logic in VisBuilder
* remove double render

Issue Resolve
opensearch-project#5942

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh added the v2.14.0 label Mar 29, 2024
@ananzh ananzh mentioned this issue Mar 29, 2024
Open
27 tasks
@ananzh ananzh self-assigned this Mar 29, 2024
@LDrago27 LDrago27 mentioned this issue Apr 15, 2024
Merged
1 task
@ananzh ananzh added v2.15.0 and removed v2.14.0 labels May 4, 2024
@ananzh
Copy link
Member

ananzh commented Jun 7, 2024

Sorry. Didn't have time to work on this. Will do it in 2.16.

@ananzh ananzh added v2.16.0 and removed v2.15.0 labels Jun 7, 2024
@ananzh ananzh mentioned this issue Jun 10, 2024
Open
10 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jun 23, 2024
@ananzh
[Discover] Allow save query to load correctly in Discover
e10fd41 
* add save query logic in Discover
* add save query logic in VisBuilder
* remove double render

Issue Resolve
opensearch-project#5942

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jun 24, 2024
@ananzh
[Discover] Allow save query to load correctly in Discover
a6821af 
* add save query logic in Discover
* add save query logic in VisBuilder
* remove double render

Issue Resolve
opensearch-project#5942

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh closed this as completed in 170ac61 Jun 26, 2024
opensearch-trigger-bot bot pushed a commit that referenced this issue Jun 26, 2024
@github-actions
[Discover] Allow save query to load correctly in Discover (#5951)
17f5cde 
* [Discover] Allow save query to load correctly in Discover

* add save query logic in Discover
* add save query logic in VisBuilder
* remove double render

Issue Resolve
#5942

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 170ac61)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
bug Something isn't working discover for discover reinvent v2.16.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashwin-pc @ananzh @mengweieric