Removes unnecessary manual resolutions
#1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Many of these resolutions brought in libraries that were no longer in the dependency tree. Those could be removed without any changes. * Upgrades `geckodriver` from v1.21.0 to v3.0.1. * No breaking changes: [CHANGELOG](https://github.com/vladikoff/node-geckodriver/tree/v3.0.1#changelog) * Upgrades `load-grunt-config` from v3.0.1 to v4.0.1. * No breaking changes: [CHANGELOG](https://github.com/firstandthird/load-grunt-config/blob/4.0.1/CHANGELOG.md) * Bumps `ejs` from v3.1.5 to v3.1.6 and `@types/ejs` from v3.0.4 to v3.1.0. Partially addresses opensearch-project#1298 Signed-off-by: Tommy Markley <markleyt@amazon.com>
tmarkley
force-pushed
the
remove-resolutions
branch
from
61101d4
to
38b4a18
Compare
7 tasks
kavilla
reviewed
Mar 1, 2022
| "**/trim": "^0.0.3", | ||
| "**/trim-newlines": "^3.0.1", |
There was a problem hiding this comment.
This was added for GHSA-7p7h-4mm5-852v?
So it's no longer needed or wasn't needed?
There was a problem hiding this comment.
It's no longer needed because of the other upstream dependency changes that have been made since. If you look at the lockfile there are no versions before 3.x that are depended on anymore (this wasn't the case when this line was added).
kavilla
approved these changes
Mar 1, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
geckodriverfrom v1.21.0 to v3.0.1.load-grunt-configfrom v3.0.1 to v4.0.1.ejsfrom v3.1.5 to v3.1.6 and@types/ejsfrom v3.0.4 to v3.1.0.Issues Resolved
Partially addresses #1298
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr