fix(Tooltip): Fixes tooltip when split series charts are used #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavilla
reviewed
Mar 8, 2022
src/plugins/vis_type_vislib/public/vislib/components/tooltip/_pointseries_tooltip_formatter.js
Outdated
Show resolved
Hide resolved
kavilla
reviewed
Mar 8, 2022
src/plugins/vis_type_vislib/public/vislib/components/tooltip/_pointseries_tooltip_formatter.js
Outdated
Show resolved
Hide resolved
ashwin-pc
force-pushed
the
fix/tooltip-label
branch
from
6d3fb99
to
4026e8c
Compare
ananzh
reviewed
Mar 15, 2022
| @@ -55,7 +56,15 @@ export function pointSeriesTooltipFormatter() { | |||
|
|
|||
| if (datum.y !== null && datum.y !== undefined) { | |||
| const value = datum.yScale ? datum.yScale * datum.y : datum.y; | |||
| addDetail(currentSeries.label, currentSeries.yAxisFormatter(value)); | |||
| let label = currentSeries.label; | |||
There was a problem hiding this comment.
seems data.yAxisLabel will give the label directly?
is there a specific reason to use datum?
data:
{xAxisOrderedValues: Array(5), xAxisFormat: {…}, xAxisLabel: 'machine.os.keyword: Descending', yAxisFormat: {…}, yAxisLabel: 'Count', …}
hits: 25
series: (15) [{…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}]
xAxisFormat: {id: 'terms', params: {…}}
xAxisFormatter: val => xConverter.convert(val)
xAxisLabel: "machine.os.keyword: Descending"
xAxisOrderedValues: (5) ['win xp', 'osx', 'win 7', 'win 8', 'ios']
yAxisFormat: {id: 'number'}
yAxisFormatter: val => yConverter.convert(val)
yAxisLabel: "Count"
zAxisFormat: {id: 'terms', params: {…}}
zAxisFormatter: val => zConverter.convert(val)
zAxisLabel: ""
[[Prototype]]: Object
There was a problem hiding this comment.
Unfortunately, when we have multiple fields on the y axis, the yAxisLabel is incorrectly set. The only way we have to correctly get the label then is from the yRaw value. Thats why i check in the next few lines to check to see if we have more than one y-axis field before using the yRaw value instead of the default label. I've added the comment below to call this out as well.
src/plugins/vis_type_vislib/public/vislib/components/tooltip/_pointseries_tooltip_formatter.js
Outdated
Show resolved
Hide resolved
ashwin-pc
force-pushed
the
fix/tooltip-label
branch
2 times, most recently
from
a5a6d46
to
7260995
Compare
ashwin-pc
force-pushed
the
fix/tooltip-label
branch
from
7260995
to
ba073c8
Compare
AMoo-Miki
reviewed
Apr 1, 2022
src/plugins/vis_type_vislib/public/vislib/components/tooltip/_pointseries_tooltip_formatter.js
Outdated
Show resolved
Hide resolved
AMoo-Miki
previously approved these changes
Apr 1, 2022
kavilla
previously approved these changes
Apr 13, 2022
There was a problem hiding this comment.
LGTM! It solves the problem but @AMoo-Miki does raise a good point about loading lodash.
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
ashwin-pc
force-pushed
the
fix/tooltip-label
branch
from
ba073c8
to
b7030cb
Compare
|
@ashwin-pc which version(s) are we targeting? Feel free to add the labels! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashwin Pc ashwinpc@amazon.com
Description
On split series charts, the y axis label is incorrect. This change uses the value from the raw table data to correctly assign the value
Issues Resolved
#1262
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr