Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] fix JUnit Reporter test #1338

Merged
merged 1 commit into from
Mar 10, 2022
Merged

[Tests] fix JUnit Reporter test #1338

merged 1 commit into from
Mar 10, 2022

Commits on Mar 10, 2022

  1. [Tests] fix JUnit Reporter test 

    Interesting flakiness in the test. After the jest upgrade, our tests
got more performant.

The JUnit Report integ test was actually expecting `anything` for a field
`time`. This `time` was calculated on elapsed time to the `0.00x` value
anything faster would actually be undefined and at that point `anything`
fails because `anything` cannot be undefined.

tl;dr: This test became flakey because our tests now run too fast.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    @kavilla
    kavilla committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    98dbcaf View commit details
    Browse the repository at this point in the history