Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes interfaced errors across Dashboards #1409

Merged
merged 4 commits into from
Apr 1, 2022

Conversation

boktorbb
Copy link
Contributor

@boktorbb boktorbb commented Mar 31, 2022

Description

Dependencies:

  • Bumps @types/enzyme and @types/cheerio
    These upgrades expose internal types, like Cheerio, to be used in functions
    • @types/cheerio: patch upgrade from ^0.22.10 to ^0.22.31
    • @types/enzyme: patch upgrade from ^3.10.5 to ^3.10.7
  • Adds a resolution for @types/react
  • Bumps classnames and removes @types/classnames
    • classnames bumped from 2.2.6 to 2.3.1
    • @types/classnames removed since the new version of classnames includes type definitions
  • Bumps enzyme-adapter-react-16 and enzyme-to-json
    • enzyme-adapter-react-16 from ^1.15.2 to ^1.15.5
    • enzyme-to-json from 3.4.4 to ^3.5.0
      Code:
  • Imports Transaction from apm-rum. Not sure how the code was working without it
  • Fixes type errors in scoped_history.ts and rendering_service.test.ts
    • In scoped_history.ts, needed to specify the type Location<HistoryLocationState>
    • In rendering_service.test.ts, needed to use || '' for a default value
  • Adds sizeMe.noPlaceholders to dashboard_viewport.test.ts to allow children to get mounted with Enzyme
  • Adds a mock for fs.read so that a unit test can pass in opensearch_config

Issues Resolved

#1393

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@boktorbb boktorbb requested a review from a team as a code owner March 31, 2022 16:09
@boktorbb boktorbb added the refactor Tech debt related tasks that need refactoring label Mar 31, 2022
@boktorbb boktorbb changed the title Fixes Interfaced Errors across Fixes Interfaced Errors across Dashboards Mar 31, 2022
@boktorbb boktorbb changed the title Fixes Interfaced Errors across Dashboards Fixes interfaced errors across Dashboards Mar 31, 2022
@kavilla
Copy link
Member

kavilla commented Mar 31, 2022

If you could rebase your test should work now.

Bishoy Boktor added 2 commits March 31, 2022 19:39
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
AMoo-Miki and others added 2 commits March 31, 2022 18:54
Signed-off-by: Miki <miki@amazon.com>
Copy link
Collaborator

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@kavilla kavilla linked an issue Apr 1, 2022 that may be closed by this pull request
@kavilla kavilla added the v2.0.0 label Apr 1, 2022
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AMoo-Miki AMoo-Miki merged commit 4c3f222 into opensearch-project:main Apr 1, 2022
kavilla pushed a commit that referenced this pull request Apr 1, 2022
Origin: #1409

* Reverts re2 back to 1.15.4 from 1.17.4 to fix build issues
* Revert to old re2 entry with correct sha hashes

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Tech debt related tasks that need refactoring v2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0] Dashboards interfaced errors during bootstrap
4 participants