Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sass lint #1413

Merged
merged 4 commits into from
Apr 1, 2022
Merged

Sass lint #1413

merged 4 commits into from
Apr 1, 2022

Conversation

ashwin-pc
Copy link
Member

Description

Originally from #1294 but fixes the failing tests in commit 757cbb525d045a47c34a5d7d7739826a8649bf80

Description from original PR:

  • Introduces standard scss rules from stylelint with only a few modifications.
  • yarn lint now runs yarn lint:style instead of yarn lint:sass.
  • Many of the files were updated with yarn lint:style --fix, but some of them had to be manually updated with overrides to adhere to the newly-introduced rules from the stylelint configuration.
  • Includes a couple fixes such as fixing the class selector for osdnSuggestionItem--value .osdSuggestionItem__text.

Issues Resolved

Resolves #551
Resolves #1139
Resolves #1151
Resolves #1152
Resolves #1154

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@ashwin-pc ashwin-pc requested a review from a team as a code owner April 1, 2022 01:24
boktorbb
boktorbb previously approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the culprit here was flex-grow?

@ashwin-pc
Copy link
Member Author

So the culprit here was flex-grow?

Yep. I also verified all the other manual css changes to make sure nothing else changed any styles.

@kavilla
Copy link
Member

kavilla commented Apr 1, 2022

Some linter errors.

Tommy Markley and others added 4 commits April 1, 2022 18:14
@ashwin-pc
Replaces sass-lint with stylelint
7b8348d 
* Introduces standard scss rules from stylelint with only a few
  modifications.
* `yarn lint` now runs `yarn lint:style` instead of `yarn lint:sass`.
* Many of the files were updated with `yarn lint:style --fix`, but some
  of them had to be manually updated with overrides to adhere to the
  newly-introduced rules from the stylelint configuration.
* Includes a couple fixes such as fixing the class selector for
  `osdnSuggestionItem--value .osdSuggestionItem__text`.

Resolves opensearch-project#551
Resolves opensearch-project#1139
Resolves opensearch-project#1151
Resolves opensearch-project#1152
Resolves opensearch-project#1154

Signed-off-by: Tommy Markley <markleyt@amazon.com>
@ashwin-pc
fix(Style): Fixes flex style
539d129 
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
@ashwin-pc
fix(lint): Fixes empty comment lint issue
397fd48 
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
@ashwin-pc
chore: rebase and updates yarn.lock
dd5869f 
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc merged commit 6c13abe into opensearch-project:main Apr 1, 2022
@ashwin-pc ashwin-pc deleted the sass-lint branch April 1, 2022 23:04
@ashwin-pc ashwin-pc mentioned this pull request Apr 1, 2022
Closed
7 tasks
@ashwin-pc ashwin-pc added v2.0.0 cve Security vulnerabilities detected by Dependabot or Mend dependencies Pull requests that update a dependency file labels Apr 1, 2022
@tmarkley
Copy link
Contributor

@ashwin-pc you're awesome, thank you!

@ananzh ananzh mentioned this pull request Jun 20, 2023
Merged
8 tasks
@BSFishy BSFishy mentioned this pull request Jul 31, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@boktorbb boktorbb boktorbb approved these changes

Assignees
No one assigned
Labels
cve Security vulnerabilities detected by Dependabot or Mend dependencies Pull requests that update a dependency file v2.0.0
Projects
None yet
Milestone
No milestone
5 participants
@ashwin-pc @kavilla @tmarkley @AMoo-Miki @boktorbb