Bumps the nested dependency of nth-check to v2.0.1
#1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nth-check` is a dependency of `cheerio > css-select`. Even though our dependency on `cheerio@0.22.0` pulls in `nth-check@~1.0.1`, its signature hasn't changed in `nth-check@2.0.1` and a resolution to bump works. Resolves opensearch-project#1081 Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
commented
Apr 2, 2022
| @@ -16970,7 +16963,7 @@ side-channel@^1.0.3, side-channel@^1.0.4: | |||
| get-intrinsic "^1.0.2" | |||
| object-inspect "^1.9.0" | |||
|
|
|||
| signal-exit@^3.0.0, signal-exit@^3.0.2, signal-exit@^3.0.3: | |||
| signal-exit@^3.0.0, signal-exit@^3.0.2, signal-exit@^3.0.3, signal-exit@^3.0.7: | |||
There was a problem hiding this comment.
This is a stylelint dep that was probably missing from an earlier commit.
AMoo-Miki
commented
Apr 2, 2022
| @@ -17565,7 +17558,7 @@ string-width@^1.0.1: | |||
| is-fullwidth-code-point "^2.0.0" | |||
| strip-ansi "^4.0.0" | |||
|
|
|||
| "string-width@^1.0.2 || 2 || 3 || 4", string-width@^4.0.0, string-width@^4.1.0, string-width@^4.2.0: | |||
| "string-width@^1.0.2 || 2 || 3 || 4", string-width@^4.0.0, string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.3: | |||
There was a problem hiding this comment.
This is a stylelint dep that was probably missing from an earlier commit.
ananzh
approved these changes
Apr 4, 2022
7 tasks
tmarkley
added
dependencies
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Mar 30, 2023
…to 2.0.1 Issue Resolve opensearch-project#1081 Backport PR opensearch-project#1422 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Mar 30, 2023
Issue Resolve opensearch-project#1081 Backport PR opensearch-project#1422 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
8 tasks
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Mar 30, 2023
Issue Resolve opensearch-project#1081 Backport PR opensearch-project#1422 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miki miki@amazon.com
Description
nth-checkis a dependency ofcheerio > css-select. Even though our dependency oncheerio@0.22.0pulls innth-check@~1.0.1, its signature hasn't changed* innth-check@2.0.1and a resolution to bump works.(*) The signature has changed but is backward compatible.
Issues Resolved
Resolves #1081
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr