Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] BWC test improvements #1447

Merged
merged 6 commits into from
Apr 15, 2022
Merged

[Tests] BWC test improvements #1447

merged 6 commits into from
Apr 15, 2022

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Apr 12, 2022 •
edited by tmarkley
Loading

Description

There were a couple issues related the BWC that was not supported
within the current iteration of the BWC script.

This fixes the following:

  • Format of files being saved with color looks unreadable in txt form
  • Exit code not being cypress exit code which would be the amount of errors.
    • Issue because texts would fail but would return 0 to test runner because the script worked
  • CI test runner expects to be able to call the same files twice (security:no-security)
    • Issue because results for both were saved at the same time while original it was wiped clean
  • Support from 'Playground' environments
  • Source to actually call the script
  • wget not available in CI runner
  • Track PID of process instead of greping since greping was not reliable.
  • OpenSearch config setup

Issues Resolved

#1392

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@kavilla
[Tests] BWC test improvements for CI
8463381 
There were a couple issues related the BWC that was not supported
within the current iteration of the BWC script.

This fixes the following:
* Format of files being saved with color looks unreadable in txt form
* Exit code not being cypress exit code which would be the amount of errors.
  * Issue because texts would fail but would return 0 to test runner because the script worked
* CI test runner expects to be able to call the same files twice (security:no-security)
  * Issue because results for both were saved at the same time while original it was wiped clean
* Support from 'Playground' environments
* Source to actually call the script
* wget not available in CI runner
* Track PID of process instead of greping since greping was not reliable.
* OpenSearch config setup

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla
Cleanup
93c2cde 
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla
Fix path of distribution
33bc9c3 
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla requested a review from a team as a code owner April 12, 2022 10:13
@kavilla kavilla linked an issue Apr 12, 2022 that may be closed by this pull request
[BUG] BWC script compat with OpenSearch CI runner #1392
Closed
tmarkley
tmarkley reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm just curious about a couple things for context and I have some suggestions for naming.

bwctest.sh Show resolved Hide resolved
bwctest.sh Outdated Show resolved Hide resolved
bwctest.sh Show resolved Hide resolved
scripts/bwctest_osd.sh Outdated Show resolved Hide resolved
scripts/bwctest_osd.sh Show resolved Hide resolved
@kavilla
set CI and clean up more vars
00e5375 
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla requested a review from tmarkley April 14, 2022 06:40
tmarkley
tmarkley previously approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Rocky! Thanks for continuing to improve these tests, much appreciated.

@kavilla
Add playground comment
121dc65 
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla requested a review from tmarkley April 15, 2022 00:33
@kavilla
Readd tests
b5c4356 
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
boktorbb
boktorbb approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ananzh
ananzh approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kavilla kavilla merged commit 4e94ea1 into opensearch-project:main Apr 15, 2022
@kavilla kavilla deleted the avillk/jenkinsbwc branch April 15, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boktorbb boktorbb boktorbb approved these changes

@ananzh ananzh ananzh approved these changes

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@tmarkley tmarkley Awaiting requested review from tmarkley

Assignees
No one assigned
Labels
ci test:bwc v2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] BWC script compat with OpenSearch CI runner
4 participants
@kavilla @tmarkley @boktorbb @ananzh