Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Consolidate menu bars #1586

Merged
merged 12 commits into from
Jun 24, 2022
Merged

[UX] Consolidate menu bars #1586

merged 12 commits into from
Jun 24, 2022

Commits on Jun 23, 2022

  1. [UX] Consolidate menu bars 

    - update branding mark unit tests
- fix header spacing at smallest breakpoint
- update custom branding functional test
- update line chart functional test ticks to account for more
ticks visisble with larger height of viz area
- update release notes

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    61562b4 View commit details
    Browse the repository at this point in the history

  2. [UX] Consolidate menu bars 

    - add branding config for expanded menu

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    db3fffe View commit details
    Browse the repository at this point in the history

  3. [UX] Consolidate menu bars 

    - revert release note addition

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    6f80630 View commit details
    Browse the repository at this point in the history

  4. [UX] Consolidate menu bars 

    - remove home link from collapsible nav

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    8c81b00 View commit details
    Browse the repository at this point in the history

  5. [UX] Consolidate menu bars 

    - Add expanded header option
- Move navControlsRight to left of help
- Rename HeaderLogo to HomeLoader
  - Serves as unified home button and global loading     indicator
  - Add title for tooltip, because purpose may not be obvious
- Rename Mark to HomeIcon
  - Uses home icon when header expanded by default
- Restore HeaderLogo for expanded header
  - Duplicate default logo, rename to match mark naming (default, dark)
- Add new nav control areas for expanded menu only
  - navControlsExpandedRight
  - navControlsExpandedCenter
- Add new body class for expanded header
  - used by styles to correctly set app height
  - remove unecessary duplicate header mixin inclusion

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    08a1776 View commit details
    Browse the repository at this point in the history

  6. [UX] Consolidate menu bars 

    - fix functional tests
  - update test subjects
  - convert home tests to ts
  - update names and methods to be more clear

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    cfd1110 View commit details
    Browse the repository at this point in the history

  7. [UX] Consolidate menu bars 

    - update snapshots

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    11f3cdc View commit details
    Browse the repository at this point in the history

  8. [UX] Consolidate menu bars 

    - add, update, improve unit tests

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    c1d9009 View commit details
    Browse the repository at this point in the history

  9. [UX] Consolidate menu bars 

    - keep expanded as default config

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    b48113c View commit details
    Browse the repository at this point in the history

  10. [UX] Consolidate menu bars 

    - restore logo link
- update functional tests

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    1f7892c View commit details
    Browse the repository at this point in the history

  11. [UX] Consolidate menu bars 

    - group dark mode branding tests

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    1a68ec6 View commit details
    Browse the repository at this point in the history

  12. [UX] Consolidate menu bars 

    - final review updates

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    a8d9e71 View commit details
    Browse the repository at this point in the history