Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MD] Fix view single document issue by updating low-level search call param #2431

Merged
merged 5 commits into from
Oct 3, 2022
Merged

[MD] Fix view single document issue by updating low-level search call param #2431

merged 5 commits into from
Oct 3, 2022

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Sep 28, 2022 •
edited
Loading

Signed-off-by: Su szhongna@amazon.com

Description

Add datasource param to low-level search call in Discover, that fixes the rendering issue of single document, while searching against data source

Issues Resolved

Part of #2400, issue reported by @abbyhu2000

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@zhongnansu
Add datasource param to low-level search call in disvcoer
1b586e0 
Signed-off-by: Su <szhongna@amazon.com>
@zhongnansu zhongnansu requested a review from a team as a code owner September 28, 2022 19:41
@zhongnansu zhongnansu self-assigned this Sep 28, 2022
@zhongnansu zhongnansu added the multiple datasource multiple datasource project label Sep 28, 2022
@zhongnansu zhongnansu mentioned this pull request Sep 28, 2022
Closed
kristenTian
kristenTian previously approved these changes Sep 28, 2022
View reviewed changes
ananzh
ananzh previously approved these changes Sep 29, 2022
View reviewed changes
@ananzh
Copy link
Member

ananzh commented Sep 29, 2022

@zhongnansu need to update the CHANGELOG.md file to pass the check

ananzh and others added 2 commits September 28, 2022 17:16
@zhongnansu zhongnansu dismissed stale reviews from ananzh and kristenTian via 378f01e September 29, 2022 00:40
@zhongnansu
Copy link
Member Author

@zhongnansu need to update the CHANGELOG.md file to pass the check

Thanks, done. Could you approve again?

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022 •
edited
Loading

Codecov Report

Merging #2431 (60e096a) into main (746b9df) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2431   +/-   ##
=======================================
  Coverage   66.75%   66.75%           
=======================================
  Files        3200     3200           
  Lines       60886    60886           
  Branches     9250     9250           
=======================================
+ Hits        40642    40646    +4     
+ Misses      18032    18029    -3     
+ Partials     2212     2211    -1
Impacted Files Coverage Δ
...cation/components/doc/use_opensearch_doc_search.ts 90.90% <ø> (ø)
packages/osd-optimizer/src/node/cache.ts 52.77% <0.00%> (+2.77%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zhongnansu zhongnansu mentioned this pull request Sep 29, 2022
Closed
7 tasks
@zhongnansu zhongnansu changed the title Add datasource param to low-level search call in Discover [MD] Fix view single document issue in Discover by updating low-level search call param Sep 29, 2022
@zhongnansu zhongnansu changed the title [MD] Fix view single document issue in Discover by updating low-level search call param [MD] Fix view single document issue by updating low-level search call param Sep 29, 2022
@kavilla kavilla added backport 2.x v2.4.0 'Issues and PRs related to version v2.4.0' labels Sep 29, 2022
@kavilla kavilla self-requested a review October 2, 2022 13:05
@kavilla kavilla merged commit 1f639b0 into opensearch-project:main Oct 3, 2022
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 3, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2022
@zhongnansu @github-actions
[MD] Fix view single document issue by updating low-level search call…
0e95721 
… param (#2431)

* Add datasource param to low-level search call in Discover
* update change log

Signed-off-by: Su <szhongna@amazon.com>
(cherry picked from commit 1f639b0)
joshuarrrr pushed a commit that referenced this pull request Oct 4, 2022
@opensearch-trigger-bot @zhongnansu
[MD] Fix view single document issue by updating low-level search call…
57f2d20 
… param (#2431) (#2483)

* Add datasource param to low-level search call in Discover
* update change log

Signed-off-by: Su <szhongna@amazon.com>
(cherry picked from commit 1f639b0)

Co-authored-by: Zhongnan Su <szhongna@amazon.com>
@AMoo-Miki AMoo-Miki added the bug Something isn't working label Nov 5, 2022
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
@zhongnansu @sipopo
[MD] Fix view single document issue by updating low-level search call…
c9ecfd9 
… param (opensearch-project#2431)

* Add datasource param to low-level search call in Discover
* update change log

Signed-off-by: Su <szhongna@amazon.com>
Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@kristenTian kristenTian kristenTian approved these changes

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

Assignees

@zhongnansu zhongnansu

Labels
backport 2.x bug Something isn't working multiple datasource multiple datasource project v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhongnansu @ananzh @codecov-commenter @kavilla @kristenTian @AMoo-Miki