Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x][MD]Address comments from UX sign-off meeting-Datasource list and create page #2642

Merged
merged 2 commits into from
Oct 24, 2022
Merged

[Backport 2.x][MD]Address comments from UX sign-off meeting-Datasource list and create page #2642

merged 2 commits into from
Oct 24, 2022

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Oct 21, 2022 •
edited
Loading

Backport commit fb4bdfa from #2625

@zhongnansu zhongnansu requested a review from a team as a code owner October 21, 2022 02:23
@yibow98 @zhongnansu
[MD]Address comments from UX signoff meeting-Datasource list and crea…
d53d8ff 
…te page (opensearch-project#2625)

Signed-off-by: Yibo Wang <yibow@amazon.com>
(cherry picked from commit fb4bdfa)
Signed-off-by: Su <szhongna@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2642 (3e02e54) into 2.x (bf43c77) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3e02e54 differs from pull request most recent head d53d8ff. Consider uploading reports for the commit d53d8ff to get more accurate results

@@           Coverage Diff           @@
##              2.x    #2642   +/-   ##
=======================================
  Coverage   66.79%   66.79%           
=======================================
  Files        3206     3206           
  Lines       61103    61105    +2     
  Branches     9305     9306    +1     
=======================================
+ Hits        40812    40814    +2     
  Misses      18061    18061           
  Partials     2230     2230
Impacted Files Coverage Δ
...components/create_form/create_data_source_form.tsx 98.36% <ø> (ø)
.../public/components/create_button/create_button.tsx 100.00% <100.00%> (ø)
...e_data_source_wizard/create_data_source_wizard.tsx 96.77% <100.00%> (ø)
...components/data_source_table/data_source_table.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zhongnansu zhongnansu added v2.4.0 'Issues and PRs related to version v2.4.0' multiple datasource multiple datasource project labels Oct 21, 2022
@zhongnansu zhongnansu changed the title [MD]Address comments from UX signoff meeting-Datasource list and crea… [Backport 2.x][MD]Address comments from UX signoff meeting-Datasource list and crea… Oct 22, 2022
@zhongnansu zhongnansu changed the title [Backport 2.x][MD]Address comments from UX signoff meeting-Datasource list and crea… [Backport 2.x][MD]Address comments from UX signoff meeting-Datasource list and create page Oct 22, 2022
kristenTian
kristenTian previously approved these changes Oct 24, 2022
View reviewed changes
@zhongnansu zhongnansu merged commit 447914b into opensearch-project:2.x Oct 24, 2022
@ashwin-pc ashwin-pc changed the title [Backport 2.x][MD]Address comments from UX signoff meeting-Datasource list and create page [Backport 2.x][MD]Address comments from UX sign-off meeting-Datasource list and create page Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zengyan-amazon zengyan-amazon zengyan-amazon approved these changes

@kristenTian kristenTian kristenTian approved these changes

Assignees
No one assigned
Labels
multiple datasource multiple datasource project v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhongnansu @codecov-commenter @zengyan-amazon @kristenTian @yibow98