[Backport 2.4] [Chore] Refactor and improve Discover field summaries #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* [Chore] Refactor and improve field summaries * Convert to typescript * Fix types * Add tests Signed-off-by: Josh Romero <rmerqg@amazon.com> * [Test] Update functional test Groups are now naturally sorted by key, which requires selecting a different date filter Signed-off-by: Josh Romero <rmerqg@amazon.com> * [Chore] Add changelog entry Signed-off-by: Josh Romero <rmerqg@amazon.com> * [Chore] Refactor columns passing, fix bugs * pass columns explicitly as props * fix branding in core mocks * fix `toBeUndefined()` usage in tests * remove leftover comment * fix test subject * condense types Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit b53d4d8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## 2.4 #2753 +/- ##
==========================================
+ Coverage 66.74% 66.75% +0.01%
==========================================
Files 3210 3210
Lines 61265 61269 +4
Branches 9359 9368 +9
==========================================
+ Hits 40889 40902 +13
+ Misses 18129 18122 -7
+ Partials 2247 2245 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This backport has merge conflicts but we are not allowed to force push on this PR. I opened another backport PR: Close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b53d4d8 from #2391.