Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x][Chore] Refactor and improve Discover field summaries #2777

Merged
merged 1 commit into from
Nov 4, 2022
Merged

[Backport 2.x][Chore] Refactor and improve Discover field summaries #2777

merged 1 commit into from
Nov 4, 2022

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Nov 3, 2022

[Backport 2.x][Chore] Refactor and improve Discover field summaries

* [Chore] Refactor and improve field summaries
* Convert to typescript
* Fix types
* Add tests
* Groups are now naturally sorted by key, which requires selecting a different date filter
* [Chore] Add changelog entry
* [Chore] Refactor columns passing, fix bugs
* pass columns explicitly as props
* fix branding in core mocks
* fix `toBeUndefined()` usage in tests
* remove leftover comment
* fix test subject
* condense types

Backport PR:
https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2391

Signed-off-by: Josh Romero <rmerqg@amazon.com>

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit b53d4d878e2f307033e46298b3fa14b6ec1bd37e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh ananzh requested a review from a team as a code owner November 3, 2022 22:16
@github-actions @ananzh
[Backport 2.x][Chore] Refactor and improve Discover field summaries
4b7df81 
* [Chore] Refactor and improve field summaries
* Convert to typescript
* Fix types
* Add tests
* Groups are now naturally sorted by key, which requires selecting a different date filter
* [Chore] Add changelog entry
* [Chore] Refactor columns passing, fix bugs
* pass columns explicitly as props
* fix branding in core mocks
* fix `toBeUndefined()` usage in tests
* remove leftover comment
* fix test subject
* condense types

Backport PR:
opensearch-project#2391

Signed-off-by: Josh Romero <rmerqg@amazon.com>

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit b53d4d8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ananzh ananzh mentioned this pull request Nov 3, 2022
Closed
@ananzh ananzh added the autocut Skip the changelog verification check on backports label Nov 3, 2022
@joshuarrrr joshuarrrr merged commit 122688c into opensearch-project:2.x Nov 4, 2022
@joshuarrrr joshuarrrr added the v2.4.0 'Issues and PRs related to version v2.4.0' label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ananzh @joshuarrrr @abbyhu2000