Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Make build scripts find and use the latest version of Node.js that satisfies engines.node #3468

Merged
merged 1 commit into from
Feb 21, 2023

Commits on Feb 21, 2023

  1. Make build scripts find and use the latest version of Node.js that sa…

    …tisfies `engines.node` (#3467)
    
    * While building distributables, Node.js runtime is downloaded to be placed in the archivea. This logicwas modified to honor a range for `engines.node` by fetching the latest release of Node.js that satisfied the range.
    * Some tests covering the build, read a version from `.node-version` to compare with the results of actual function runs; these were changed to either use mocked values or honor the range and use the latest Node.js version.
    * Some variable and functions referred to `engines.node` as a version; they were corrected to call it a range.
    
    Signed-off-by: Miki <miki@amazon.com>
    (cherry picked from commit f5ee06d)
    Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    
    # Conflicts:
    #	CHANGELOG.md
    github-actions[bot] committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    4472555 View commit details
    Browse the repository at this point in the history