Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][TSVB] Fix serial diff agg link #3503

Merged
merged 1 commit into from
Feb 28, 2023
Merged

[BUG][TSVB] Fix serial diff agg link #3503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Viz Builder] Add index pattern info when loading embeddable ([#2363](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2363))
- Fixes management app breadcrumb error ([#2344](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2344))
- [BUG] Fix suggestion list cutoff issue ([#2607](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2607))
- [TSVB] Fixes undefined serial diff aggregation documentation link ([#3503](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3503))

### 🚞 Infrastructure

Expand Down
5 changes: 3 additions & 2 deletions src/plugins/vis_type_timeseries/public/application/components/aggs/serial_diff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ export const SerialDiffAgg = (props) => {
const handleNumberChange = createNumberHandler(handleChange);

const htmlId = htmlIdGenerator();
const docLinks = useOpenSearchDashboards().services.docLinks;
const serialDiffDoc = useOpenSearchDashboards().services.docLinks?.links.opensearch.aggregations
.pipeline.serial_diff;

return (
<AggRow
Expand Down Expand Up @@ -111,7 +112,7 @@ export const SerialDiffAgg = (props) => {
id="visTypeTimeseries.serialDiff.lagLabel"
defaultMessage="Lag"
description={`'Lag' refers to the parameter name of the serial diff translation
${docLinks.services.links.opensearch.aggregations.pipeline.serial_diff}.
${serialDiffDoc}.
This should only be translated if there is a reasaonable word explaining what that parameter does.`}
/>
}
Expand Down