Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.x] [BUG][TSVB] Fix serial diff agg link #3504

Merged
merged 1 commit into from
Mar 2, 2023
Merged

[Backport 1.x] [BUG][TSVB] Fix serial diff agg link #3504

merged 1 commit into from
Mar 2, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 69bcbfe from #3503.

@github-actions
[BUG][TSVB] Fix serial diff agg link (#3503)
6ff5ab4 
Doc link was invalid and causing an undefined error. This
prevented the UI from mounting properly.

Issue(s) resolved:
* #3498
* #3327

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 69bcbfe)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@kavilla kavilla added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Feb 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #3504 (6ff5ab4) into 1.x (9a4f6ad) will increase coverage by 0.04%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              1.x    #3504      +/-   ##
==========================================
+ Coverage   67.45%   67.49%   +0.04%     
==========================================
  Files        3044     3044              
  Lines       58696    58696              
  Branches     8902     8902              
==========================================
+ Hits        39591    39617      +26     
+ Misses      16952    16931      -21     
+ Partials     2153     2148       -5
Flag Coverage Δ
Linux 67.45% <0.00%> (ø)
Windows 67.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../public/application/components/aggs/serial_diff.js 18.18% <0.00%> (ø)
...ic/application/models/sense_editor/sense_editor.ts 65.77% <0.00%> (+0.88%) ⬆️
src/setup_node_env/harden/child_process.js 88.46% <0.00%> (+3.84%) ⬆️
src/dev/build/lib/config.ts 85.29% <0.00%> (+5.88%) ⬆️
...ges/osd-apm-config-loader/src/config.test.mocks.ts 100.00% <0.00%> (+8.69%) ⬆️
packages/osd-cross-platform/src/path.ts 86.04% <0.00%> (+37.20%) ⬆️
src/dev/build/lib/get_build_number.ts 100.00% <0.00%> (+42.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AMoo-Miki AMoo-Miki added the autocut Skip the changelog verification check on backports label Mar 1, 2023
@ashwin-pc ashwin-pc merged commit ba11c44 into 1.x Mar 2, 2023
@github-actions github-actions bot deleted the backport/backport-3503-to-1.x branch March 2, 2023 01:21
@joshuarrrr joshuarrrr added not in release PRs backported to already shipped releases with no future release planned v1.3.9 and removed not in release PRs backported to already shipped releases with no future release planned labels Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@kavilla kavilla kavilla approved these changes

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v1.3.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codecov-commenter @AMoo-Miki @kavilla @joshuarrrr @ashwin-pc