Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.3] [BUG][TSVB] Fix serial diff agg link #3505

Merged
merged 2 commits into from
Mar 7, 2023
Merged

[Backport 1.3] [BUG][TSVB] Fix serial diff agg link #3505

merged 2 commits into from
Mar 7, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 69bcbfe from #3503.

@github-actions
[BUG][TSVB] Fix serial diff agg link (#3503)
a5f4314 
Doc link was invalid and causing an undefined error. This
prevented the UI from mounting properly.

Issue(s) resolved:
* #3498
* #3327

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 69bcbfe)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@kavilla kavilla added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Feb 28, 2023
@AMoo-Miki AMoo-Miki added the autocut Skip the changelog verification check on backports label Mar 1, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3505 (37eadc9) into 1.3 (ddd7f50) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              1.3    #3505      +/-   ##
==========================================
- Coverage   67.49%   67.44%   -0.05%     
==========================================
  Files        3044     3044              
  Lines       58694    58694              
  Branches     8902     8902              
==========================================
- Hits        39613    39589      -24     
- Misses      16932    16952      +20     
- Partials     2149     2153       +4
Flag Coverage Δ
Linux 67.44% <0.00%> (ø)
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../public/application/components/aggs/serial_diff.js 18.18% <0.00%> (ø)
src/dev/build/lib/get_build_number.ts 57.14% <0.00%> (-42.86%) ⬇️
packages/osd-cross-platform/src/path.ts 48.83% <0.00%> (-37.21%) ⬇️
...ges/osd-apm-config-loader/src/config.test.mocks.ts 91.30% <0.00%> (-8.70%) ⬇️
src/dev/build/lib/config.ts 79.41% <0.00%> (-5.89%) ⬇️
src/setup_node_env/harden/child_process.js 84.61% <0.00%> (-3.85%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr
Copy link
Member

ignoring failed whitesource check

@joshuarrrr joshuarrrr merged commit 5c1fe29 into 1.3 Mar 7, 2023
@joshuarrrr joshuarrrr deleted the backport/backport-3503-to-1.3 branch March 7, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@kavilla kavilla kavilla approved these changes

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v1.3.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecov-commenter @joshuarrrr @AMoo-Miki @kavilla