Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [BUG][TSVB] Fix serial diff agg link #3506

Merged
merged 1 commit into from
Mar 2, 2023
Merged

[Backport 2.x] [BUG][TSVB] Fix serial diff agg link #3506

merged 1 commit into from
Mar 2, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 69bcbfe from #3503.

@github-actions
[BUG][TSVB] Fix serial diff agg link (#3503)
24f46f7 
Doc link was invalid and causing an undefined error. This
prevented the UI from mounting properly.

Issue(s) resolved:
* #3498
* #3327

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 69bcbfe)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner February 28, 2023 20:28
@kavilla kavilla added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Feb 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3506 (24f46f7) into 2.x (4d1a531) will increase coverage by 0.00%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              2.x    #3506   +/-   ##
=======================================
  Coverage   66.44%   66.45%           
=======================================
  Files        3205     3205           
  Lines       61567    61567           
  Branches     9497     9497           
=======================================
+ Hits        40909    40915    +6     
+ Misses      18386    18382    -4     
+ Partials     2272     2270    -2
Flag Coverage Δ
Linux 66.40% <0.00%> (+<0.01%) ⬆️
Windows 66.39% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../public/application/components/aggs/serial_diff.js 18.18% <0.00%> (ø)
...ic/application/models/sense_editor/sense_editor.ts 65.77% <0.00%> (+0.88%) ⬆️
packages/osd-optimizer/src/node/cache.ts 53.94% <0.00%> (+2.63%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AMoo-Miki AMoo-Miki added the autocut Skip the changelog verification check on backports label Mar 1, 2023
@joshuarrrr
Copy link
Member

ignoring mend error/failure

@joshuarrrr joshuarrrr merged commit 1c042cd into 2.x Mar 2, 2023
@joshuarrrr joshuarrrr deleted the backport/backport-3503-to-2.x branch March 2, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@kavilla kavilla kavilla approved these changes

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecov-commenter @joshuarrrr @AMoo-Miki @kavilla