Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]gitignore #3762

Merged
merged 1 commit into from
Apr 4, 2023
Merged

[FIX]gitignore #3762

merged 1 commit into from
Apr 4, 2023

Conversation

Aigerim-ai
Copy link
Contributor

@Aigerim-ai Aigerim-ai commented Apr 1, 2023

Description

added opensearch-dashboards-docker-dev/

Issues Resolved

fixes #3667
This is convenience change for our developers.
For those who are using docker, they need to delete opensearch-dashboards-docker-dev file everytime they commit

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Aigerim Suleimenova <aigerim.suleimenova27@gmail.com>
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for the change!

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #3762 (9f248af) into main (1e127b0) will increase coverage by 0.02%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3762      +/-   ##
==========================================
+ Coverage   66.41%   66.43%   +0.02%     
==========================================
  Files        3206     3210       +4     
  Lines       61597    61677      +80     
  Branches     9503     9522      +19     
==========================================
+ Hits        40909    40977      +68     
- Misses      18410    18419       +9     
- Partials     2278     2281       +3     
Flag Coverage Δ
Linux 66.38% <ø> (-0.04%) ⬇️
Windows 66.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 52 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashwin-pc
Copy link
Member

@Aigerim-ai Can you add a changelog entry for your change?

@Aigerim-ai
Copy link
Contributor Author

Aigerim-ai commented Apr 4, 2023

Hello! it opens new issue #3765

@joshuarrrr joshuarrrr added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Apr 4, 2023
@joshuarrrr
Copy link
Member

I think we can skip the changelog on this minor change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 backport 2.x OSCI Open Source Contributor Initiative Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v1.3.10 v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] .gitignore update
5 participants