Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix header icon #3914

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3cca088 from #3910.

* fixes header change
* Update src/core/public/chrome/ui/header/header_help_menu.tsx
* fixes snapshots

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 3cca088)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3914 (f9d3d1e) into 2.x (5b3ebd4) will decrease coverage by 0.06%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x    #3914      +/-   ##
==========================================
- Coverage   66.44%   66.39%   -0.06%     
==========================================
  Files        3227     3227              
  Lines       62028    62028              
  Branches     9591     9591              
==========================================
- Hits        41217    41183      -34     
- Misses      18512    18540      +28     
- Partials     2299     2305       +6     
Flag Coverage Δ
Linux 66.39% <ø> (+<0.01%) ⬆️
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../core/public/chrome/ui/header/header_help_menu.tsx 35.55% <ø> (ø)

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Apr 21, 2023
@manasvinibs manasvinibs merged commit d58c9ce into 2.x Apr 21, 2023
@github-actions github-actions bot deleted the backport/backport-3910-to-2.x branch April 21, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants