Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.8] Adds plugin manifest config to define OpenSearch plugin dependency and verifies if it is installed on the cluster #4195

Merged
merged 1 commit into from
Jun 1, 2023
Merged

[Backport 2.8] Adds plugin manifest config to define OpenSearch plugin dependency and verifies if it is installed on the cluster #4195

merged 1 commit into from
Jun 1, 2023
+230 −3

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f017eaa from #3116.

@github-actions
Adds plugin manifest config to define OpenSearch plugin dependency an…
f5a68e6 
…d verifies if it is installed (#3116)

Resolves Issue -#2799

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
(cherry picked from commit f017eaa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ananzh ananzh added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023 •
edited
Loading

Codecov Report

Merging #4195 (f5a68e6) into 2.8 (23b1743) will increase coverage by 0.00%.
The diff coverage is 91.30%.

@@           Coverage Diff           @@
##              2.8    #4195   +/-   ##
=======================================
  Coverage   66.35%   66.36%           
=======================================
  Files        3229     3229           
  Lines       62091    62114   +23     
  Branches     9611     9616    +5     
=======================================
+ Hits        41203    41222   +19     
- Misses      18569    18572    +3     
- Partials     2319     2320    +1
Flag Coverage Δ
Linux 66.31% <91.30%> (+<0.01%) ⬆️
Windows 66.31% <91.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/server/plugins/types.ts 100.00% <ø> (ø)
src/core/server/plugins/plugins_system.ts 90.32% <85.71%> (-0.82%) ⬇️
...server/plugins/discovery/plugin_manifest_parser.ts 84.37% <100.00%> (+2.23%) ⬆️
src/core/server/plugins/plugin.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@kavilla kavilla merged commit e85ea81 into 2.8 Jun 1, 2023
@github-actions github-actions bot deleted the backport/backport-3116-to-2.8 branch June 1, 2023 05:29
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 1, 2023
@kavilla
Revert "Adds plugin manifest config to define OpenSearch plugin depen…
5365a3b 
…dency and verifies if it is installed (opensearch-project#3116) (opensearch-project#4195)"

This reverts commit e85ea81.
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 1, 2023
@kavilla
Revert "Adds plugin manifest config to define OpenSearch plugin depen…
d71ced2 
…dency and verifies if it is installed (opensearch-project#3116) (opensearch-project#4195)"

This reverts commit e85ea81.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Jun 1, 2023
@kavilla
Revert "Adds plugin manifest config to define OpenSearch plugin depen…
636ae73 
…dency and verifies if it is installed (#3116) (#4195)" (#4205)

This reverts commit e85ea81.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@joshuarrrr joshuarrrr added the not in release PRs backported to already shipped releases with no future release planned label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@ananzh ananzh ananzh approved these changes

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

Assignees
No one assigned
Labels
not in release PRs backported to already shipped releases with no future release planned Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kavilla @ananzh @joshuarrrr