Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group ViewEvents option and bug fix #4309

Merged

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Jun 19, 2023

Description

Group ViewEvents option and bug fixes

Issues Resolved

N/A

Testing the changes

Manual testing with the Alerting and AD plugins

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #4309 (95c957b) into feature/feature-anywhere (2362c35) will increase coverage by 0.00%.
The diff coverage is 40.00%.

❗ Current head 95c957b differs from pull request most recent head cca64a9. Consider uploading reports for the commit cca64a9 to get more accurate results

@@                    Coverage Diff                    @@
##           feature/feature-anywhere    #4309   +/-   ##
=========================================================
  Coverage                     66.36%   66.36%           
=========================================================
  Files                          3271     3271           
  Lines                         62995    62997    +2     
  Branches                       9756     9758    +2     
=========================================================
+ Hits                          41808    41810    +2     
  Misses                        18840    18840           
  Partials                       2347     2347           
Flag Coverage Δ
Linux 66.31% <40.00%> (+<0.01%) ⬆️
Windows 66.31% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ter/public/view_events_flyout/components/utils.tsx 1.88% <0.00%> (-0.04%) ⬇️
src/plugins/vis_augmenter/public/utils/utils.ts 88.33% <50.00%> (-1.67%) ⬇️
...vents_flyout/actions/view_events_option_action.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@lezzago lezzago merged commit 12b6d44 into opensearch-project:feature/feature-anywhere Jun 19, 2023
17 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants