Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow queryStart to be passed into fetchVisEmbeddable #4336

Merged

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Jun 20, 2023

Description

This allows the show visualization piece to work from the plugins since they need to call fetchVisEmbeddable

Issues Resolved

N/A

Testing the changes

Setup remote cluster with this built and tested against Alerting plugin

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #4336 (5e5dd93) into feature/feature-anywhere (12b6d44) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@                     Coverage Diff                      @@
##           feature/feature-anywhere    #4336      +/-   ##
============================================================
- Coverage                     66.36%   66.36%   -0.01%     
============================================================
  Files                          3271     3271              
  Lines                         62997    62998       +1     
  Branches                       9758     9759       +1     
============================================================
  Hits                          41811    41811              
  Misses                        18840    18840              
- Partials                       2346     2347       +1     
Flag Coverage Δ
Linux 66.31% <0.00%> (-0.01%) ⬇️
Windows 66.31% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ter/public/view_events_flyout/components/utils.tsx 1.85% <0.00%> (-0.04%) ⬇️

... and 2 files with indirect coverage changes

@lezzago lezzago merged commit 4536bb8 into opensearch-project:feature/feature-anywhere Jun 21, 2023
27 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants