Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Bump node-sass to a version that uses a newer libsass #4670

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport bf6e887 from #4651.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #4670 (46c19cc) into 2.x (a9f0e53) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #4670   +/-   ##
=======================================
  Coverage   66.10%   66.10%           
=======================================
  Files        3315     3315           
  Lines       63891    63891           
  Branches    10121    10121           
=======================================
  Hits        42238    42238           
+ Misses      19245    19168   -77     
- Partials     2408     2485   +77     
Flag Coverage Δ
Linux_1 34.77% <ø> (ø)
Linux_2 55.07% <ø> (ø)
Linux_3 43.08% <ø> (ø)
Linux_4 35.10% <ø> (ø)
Windows_1 34.78% <ø> (ø)
Windows_2 55.03% <ø> (ø)
Windows_3 43.09% <ø> (ø)
Windows_4 35.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

Also:
* bump `sass-loader` to a version that supports this `node-sass`

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit bf6e887)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@AMoo-Miki AMoo-Miki force-pushed the backport/backport-4651-to-2.x branch from 1317e59 to aa4615e Compare August 3, 2023 21:31
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
@joshuarrrr joshuarrrr merged commit f943320 into 2.x Aug 4, 2023
50 of 51 checks passed
@joshuarrrr joshuarrrr deleted the backport/backport-4651-to-2.x branch August 4, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants