Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer][Discover 2.0] Change to inspect icon and update hint msg #4827

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Aug 25, 2023

Description

  • Change expand icon to inspect icon

before

Screenshot 2023-08-25 at 11 34 27

after

Screenshot 2023-08-25 at 11 31 35

Issues Resolved

#4826

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #4827 (7ca8c02) into feature/data-explorer (521f306) will decrease coverage by 0.14%.
Report is 11 commits behind head on feature/data-explorer.
The diff coverage is 75.72%.

❗ Current head 7ca8c02 differs from pull request most recent head 4f486e4. Consider uploading reports for the commit 4f486e4 to get more accurate results

@@                    Coverage Diff                    @@
##           feature/data-explorer    #4827      +/-   ##
=========================================================
- Coverage                  66.50%   66.37%   -0.14%     
=========================================================
  Files                       3289     3388      +99     
  Lines                      62821    64707    +1886     
  Branches                    9788    10302     +514     
=========================================================
+ Hits                       41782    42950    +1168     
- Misses                     18658    19295     +637     
- Partials                    2381     2462      +81     
Flag Coverage Δ
Linux_1 34.91% <82.00%> (?)
Linux_2 55.13% <77.22%> (?)
Linux_3 43.99% <81.63%> (?)
Linux_4 35.10% <82.00%> (?)
Windows ?
Windows_1 34.92% <82.00%> (?)
Windows_2 55.10% <77.22%> (?)
Windows_3 43.99% <81.63%> (?)
Windows_4 35.10% <82.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/osd-babel-preset/node_preset.js 100.00% <ø> (ø)
...osd-opensearch-archiver/src/lib/docs/test_stubs.ts 68.75% <ø> (ø)
...ch-archiver/src/lib/indices/create_index_stream.ts 69.76% <ø> (ø)
...ch-archiver/src/lib/indices/delete_index_stream.ts 50.00% <ø> (ø)
...ver/src/lib/indices/opensearch_dashboards_index.ts 0.00% <0.00%> (ø)
packages/osd-pm/src/utils/package_json.ts 66.66% <ø> (ø)
packages/osd-ui-shared-deps/theme.ts 41.66% <0.00%> (ø)
src/core/public/chrome/chrome_service.mock.ts 100.00% <ø> (ø)
...c/core/public/chrome/ui/header/collapsible_nav.tsx 95.45% <ø> (+0.90%) ⬆️
src/core/public/chrome/ui/header/header.tsx 75.00% <ø> (+1.66%) ⬆️
... and 37 more

... and 312 files with indirect coverage changes

Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this going as is but I dont think the icon needs to toggle between the two states. We can follow up with that in a future PR unless you want to address it here :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This icon does not need to toggle between inspect and minimize

@ananzh ananzh merged commit bef76fe into opensearch-project:feature/data-explorer Aug 26, 2023
38 of 39 checks passed
ashwin-pc pushed a commit to ashwin-pc/OpenSearch-Dashboards that referenced this pull request Aug 26, 2023
…msg (opensearch-project#4827)

Issue Resolve
opensearch-project#4826

Signed-off-by: ananzh <ananzh@amazon.com>
(cherry picked from commit bef76fe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data explorer Issues related to the Data Explorer project discover for discover reinvent v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants